From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C42C433E0 for ; Tue, 7 Jul 2020 00:40:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAC1620663 for ; Tue, 7 Jul 2020 00:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727079AbgGGAkm (ORCPT ); Mon, 6 Jul 2020 20:40:42 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50090 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725942AbgGGAkm (ORCPT ); Mon, 6 Jul 2020 20:40:42 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jsbf0-003vqW-Tz; Tue, 07 Jul 2020 02:40:34 +0200 Date: Tue, 7 Jul 2020 02:40:34 +0200 From: Andrew Lunn To: Chris Healy Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , kuba@kernel.org, Russell King - ARM Linux , netdev , linux-kernel Subject: Re: [PATCH net-next v2] net: sfp: Unique GPIO interrupt names Message-ID: <20200707004034.GA935794@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > index 73c2969f11a4..193a124c26c4 100644 > --- a/drivers/net/phy/sfp.c > +++ b/drivers/net/phy/sfp.c > @@ -2239,6 +2239,7 @@ static int sfp_probe(struct platform_device *pdev) > const struct sff_data *sff; > struct i2c_adapter *i2c; > struct sfp *sfp; > + char *sfp_irq_name; > int err, i; Hi Chris Reverse Christmas tree. > > sfp = sfp_alloc(&pdev->dev); > @@ -2349,12 +2350,16 @@ static int sfp_probe(struct platform_device *pdev) > continue; > } > > + sfp_irq_name = devm_kasprintf(sfp->dev, GFP_KERNEL, > + "%s-%s", dev_name(sfp->dev), > + gpio_of_names[i]); > + Did you run ./scripts/checkpatch.pl on this patch? I suspect it will complain about spaces, not tabs. Humm, actually, all tabs seem to of been converted to spaces. Something David often recommends. email the patch to yourself, and then apply it using git am. If it does not apply cleanly, something has mangled it. Andrew