public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Christoph Hellwig <hch@infradead.org>,
	Simon Arlott <simon@octiron.net>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] scsi: sd: stop SSD (non-rotational) disks before reboot
Date: Tue, 7 Jul 2020 11:18:05 +0100	[thread overview]
Message-ID: <20200707101805.GA11097@infradead.org> (raw)
In-Reply-To: <20200705213125.GC8285@khazad-dum.debian.net>

On Sun, Jul 05, 2020 at 06:31:25PM -0300, Henrique de Moraes Holschuh wrote:
> On Thu, 18 Jun 2020, Christoph Hellwig wrote:
> > > For SSDs, I don't think an extra stop should ever be an issue.
> > 
> > Extra shutdowns will usually cause additional P/E cycles.
> 
> I am not so sure.  We're talking about enforcing clean shutdowns here
> (from the SSD PoV).
> 
> A system reboot takes enough time that the SSD is likely to do about the
> same amount of P cycles commiting to FLASH any important data that it
> would trigger by a shutdown sequence, simply because it should not keep
> important data in RAM for too long.  By extension, it would not increase
> E cycles either.
> 
> OTOH, unclean shutdowns *always* cause extra P/E, and that's if you're
> lucky enough for it to not cause anything much worse.

The point is - with a normal system that doesn't required your odd
reboot method we'll normally not shut down the SSD at all, and that
won't require a P/E cycle.

But the whole thing is a moot point - if you quirk your system to
require a poweroff to reboot the kernel should trat it as a power off
as far as shutdown/remove callbacks are concerned and everything will
just work as intended.

  reply	other threads:[~2020-07-07 10:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 18:49 [PATCH] scsi: sd: stop SSD (non-rotational) disks before reboot Simon Arlott
2020-06-17 19:19 ` Bart Van Assche
2020-06-17 19:32   ` Simon Arlott
2020-06-18  7:21 ` Christoph Hellwig
2020-06-18 12:25   ` Simon Arlott
2020-06-18 13:49     ` Christoph Hellwig
2020-07-05 21:31       ` Henrique de Moraes Holschuh
2020-07-07 10:18         ` Christoph Hellwig [this message]
2020-06-18  8:36 ` Damien Le Moal
2020-06-18 12:25   ` Simon Arlott
2020-06-18 23:31     ` Damien Le Moal
2020-06-28 18:23       ` Simon Arlott
2020-06-30  1:05         ` Damien Le Moal
2020-06-23 13:36   ` Pavel Machek
2020-06-28 18:22     ` Simon Arlott
2020-06-23 20:42   ` Henrique de Moraes Holschuh
2020-06-28 18:31     ` Simon Arlott
2020-06-28 19:42       ` Henrique de Moraes Holschuh
2020-06-30  3:31     ` Ming Lei
2020-07-02 21:16       ` Pavel Machek
2020-07-03 14:13         ` David Laight
2020-07-04 11:49           ` Pavel Machek
2020-07-05 22:19       ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707101805.GA11097@infradead.org \
    --to=hch@infradead.org \
    --cc=corbet@lwn.net \
    --cc=hmh@hmh.eng.br \
    --cc=jejb@linux.ibm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=simon@octiron.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox