From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762B3C433DF for ; Tue, 7 Jul 2020 23:59:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52AF22073E for ; Tue, 7 Jul 2020 23:59:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="E5Bv52U3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729408AbgGGX7D (ORCPT ); Tue, 7 Jul 2020 19:59:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728294AbgGGX7C (ORCPT ); Tue, 7 Jul 2020 19:59:02 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CD0CC08C5DC for ; Tue, 7 Jul 2020 16:59:02 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id a14so14553355pfi.2 for ; Tue, 07 Jul 2020 16:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rdv9aWYxdWzi7YuZEHxXGYFHP62AjpgpR6iHCVdleuI=; b=E5Bv52U3XPTKQk/JUCHmdsxbrjEBV7kFdiIQaCyIgOqHSS133VrkT0uweCNwnEouhB D6ChoBGorNNXQRd5vuzzcx1j8GUi9ZQpXJ/p70YeFpe/j26iafcL6ByrwDGUqHuT5A/I RFDzv7/AV7eJ4KbBcjAjcMhpYwiZT3d6/TEnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rdv9aWYxdWzi7YuZEHxXGYFHP62AjpgpR6iHCVdleuI=; b=rdaAIHGqBn84SR0Oz8rLeTWAikn0EMmz/IlzIPwn97b85me/wYJ7zAANdRasUzl9l4 Dn6WL3+Nq+LHbudcoXcTL4npPKuiJExZs7KPTqFQRVvhA90Rws58qS5OZ5h5l3AkKBDY 50TL9zaa+rdLlu9cNvfdUoGTFuTd5Dzb+cKEZxxMMaoSXg7GaAXLnhcQEc93dqAl1XgD siXiKXLP0bXZZ3Im5RBGfjSXTz5CJ/lk2eVwYou4dBtSV2LLM51zfR6hV6zTqh8JPj9H EtsVtvF5uRlypVwkYHfB/gwnwR4ORvLUIPfSZP5YF28nxePZzjYD+cYuey7IekAG2uwS Pdrg== X-Gm-Message-State: AOAM530D2oOLRpB8ryx+rteDPZjfp/bsng7UKuUOAdn9pBC8KUj71Q/d QhISe4Y86HFAMIOpmC6OKLkLHQ== X-Google-Smtp-Source: ABdhPJzYvJrtZ8JwyO03TQIq0tpFYVl2WHcKj9p5wk7nKZXNGQu8Fct93qp7eRhs4GS/cWugEjuxmw== X-Received: by 2002:a62:404:: with SMTP id 4mr53377463pfe.133.1594166341548; Tue, 07 Jul 2020 16:59:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w123sm15793025pfd.2.2020.07.07.16.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 16:59:00 -0700 (PDT) Date: Tue, 7 Jul 2020 16:58:59 -0700 From: Kees Cook To: Scott Branden Cc: Luis Chamberlain , Wolfram Sang , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , Mimi Zohar , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v10 3/9] firmware: add request_partial_firmware_into_buf Message-ID: <202007071657.55C2CFA57@keescook> References: <20200706232309.12010-1-scott.branden@broadcom.com> <20200706232309.12010-4-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200706232309.12010-4-scott.branden@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 06, 2020 at 04:23:03PM -0700, Scott Branden wrote: > Add request_partial_firmware_into_buf to allow for portions > of firmware file to be read into a buffer. Necessary where firmware > needs to be loaded in portions from file in memory constrained systems. Just tear out the differing "id" and just use FW_OPT_PARTIAL and I think if Luis is happy, you're all set. -- Kees Cook