Re: [PATCH v10 1/4] unicode: Add utf8_casefold_hash

Eric Biggers
2020-07-08T01:36:08Z

On Tue, Jul 07, 2020 at 04:31:20AM -0700, Daniel Rosenberg wrote:
> This adds a case insensitive hash function to allow taking the hash
> without needing to allocate a casefolded copy of the string.
>
> The existing d_hash implementations for casefolding allocates memory
> within rcu-walk, by avoiding it we can be more efficient and avoid
> worrying about a failed allocation.
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>

You can add:

Reviewed-by: Eric Biggers <ebiggers@google.com>

If you have a chance please fix the grammar in the commit message though:

"The existing d_hash implementations for casefolding allocate memory
within rcu-walk. By avoiding this we can be more efficient and avoid
worrying about a failed allocation."

- Eric