Re: [PATCH v10 4/4] ext4: Use generic casefolding support

Eric Biggers
2020-07-08T01:44:43Z

On Tue, Jul 07, 2020 at 04:31:23AM -0700, Daniel Rosenberg wrote:
> This switches ext4 over to the generic support provided in
> the previous patch.
>
> Since casefolded dentries behave the same in ext4 and f2fs, we decrease
> the maintenance burden by unifying them, and any optimizations will
> immediately apply to both.
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>
> ---
> fs/ext4/dir.c | 64 ++-----------------------------------------------
> fs/ext4/ext4.h | 12 ----------
> fs/ext4/hash.c | 2 +-
> fs/ext4/namei.c | 20 +++++++---------
> fs/ext4/super.c | 12 +++++-----
> 5 files changed, 17 insertions(+), 93 deletions(-)
>

Looks good, you can add:

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric