* [PATCH] mfd/axp20x-i2c: Fix "CONFIG_ACPI" is not defined warning
@ 2020-07-07 11:00 Axel Lin
2020-07-08 7:30 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2020-07-07 11:00 UTC (permalink / raw)
To: Lee Jones; +Cc: Chen-Yu Tsai, Carlo Caione, linux-kernel, Axel Lin
Fix below build warning:
drivers/mfd/axp20x-i2c.c:82:5: warning: "CONFIG_ACPI" is not defined, evaluates to 0 [-Wundef]
82 | #if CONFIG_ACPI
| ^~~~~~~~~~~
Fixes: 20f359cb236b ("mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/axp20x-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
index bd271fbe1ec1..3c930316d48b 100644
--- a/drivers/mfd/axp20x-i2c.c
+++ b/drivers/mfd/axp20x-i2c.c
@@ -79,7 +79,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
-#if CONFIG_ACPI
+#ifdef CONFIG_ACPI
static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
{
.id = "INT33F4",
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd/axp20x-i2c: Fix "CONFIG_ACPI" is not defined warning
2020-07-07 11:00 [PATCH] mfd/axp20x-i2c: Fix "CONFIG_ACPI" is not defined warning Axel Lin
@ 2020-07-08 7:30 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-07-08 7:30 UTC (permalink / raw)
To: Axel Lin; +Cc: Chen-Yu Tsai, Carlo Caione, linux-kernel
On Tue, 07 Jul 2020, Axel Lin wrote:
> Fix below build warning:
>
> drivers/mfd/axp20x-i2c.c:82:5: warning: "CONFIG_ACPI" is not defined, evaluates to 0 [-Wundef]
> 82 | #if CONFIG_ACPI
> | ^~~~~~~~~~~
>
> Fixes: 20f359cb236b ("mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/axp20x-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This should already be fixed.
Thanks anyway Axel.
> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> index bd271fbe1ec1..3c930316d48b 100644
> --- a/drivers/mfd/axp20x-i2c.c
> +++ b/drivers/mfd/axp20x-i2c.c
> @@ -79,7 +79,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>
> -#if CONFIG_ACPI
> +#ifdef CONFIG_ACPI
> static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
> {
> .id = "INT33F4",
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-08 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-07 11:00 [PATCH] mfd/axp20x-i2c: Fix "CONFIG_ACPI" is not defined warning Axel Lin
2020-07-08 7:30 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox