Re: [PATCH 5/6] phy: exynos5-usbdrd: use correct format for structure description

Marek Szyprowski
2020-07-09T07:13:56Z

On 08.07.2020 15:28, Vinod Koul wrote:
> We get warning with W=1 build:
> drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function
> parameter or member 'phys' not described in 'exynos5_usbdrd_phy'
> drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function
> parameter or member 'vbus' not described in 'exynos5_usbdrd_phy'
> drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function
> parameter or member 'vbus_boost' not described in 'exynos5_usbdrd_phy'
>
> These members are provided with description but format is not quite
> right resulting in above warnings
>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index eb06ce9f748f..bfb0e8914103 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -180,14 +180,14 @@ struct exynos5_usbdrd_phy_drvdata {
> * @utmiclk: clock for utmi+ phy
> * @itpclk: clock for ITP generation
> * @drv_data: pointer to SoC level driver data structure
> - * @phys[]: array for 'EXYNOS5_DRDPHYS_NUM' number of PHY
> + * @phys: array for 'EXYNOS5_DRDPHYS_NUM' number of PHY
> * instances each with its 'phy' and 'phy_cfg'.
> * @extrefclk: frequency select settings when using 'separate
> * reference clocks' for SS and HS operations
> * @ref_clk: reference clock to PHY block from which PHY's
> * operational clocks are derived
> - * vbus: VBUS regulator for phy
> - * vbus_boost: Boost regulator for VBUS present on few Exynos boards
> + * @vbus: VBUS regulator for phy
> + * @vbus_boost: Boost regulator for VBUS present on few Exynos boards
> */
> struct exynos5_usbdrd_phy {
> struct device *dev;

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland