From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D54C433E0 for ; Wed, 8 Jul 2020 18:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3386F206F6 for ; Wed, 8 Jul 2020 18:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594232049; bh=7dXnrSdNo3mR2eRfQtUcUioXGNY6rLTR4PxhcaEmK5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jcG9S+Jeo5MEViiLLNTgTA3zvwG8sFFPI8kiUnKrYNE7TAFctu2wBP2PInKj+9xi6 w7G+zYu+GF4VORnrLuP9wbgI79aJVqTtw8CT8Im9tocBfG3TpAR6C8hmU4Zr6LSTOG hb4o3FtDkO0Ac6DGsXOVwNASyKIbrDOrQWbyL7Rk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726408AbgGHSOH (ORCPT ); Wed, 8 Jul 2020 14:14:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:39140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgGHSOH (ORCPT ); Wed, 8 Jul 2020 14:14:07 -0400 Received: from embeddedor (unknown [201.162.240.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4BD520760; Wed, 8 Jul 2020 18:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594232046; bh=7dXnrSdNo3mR2eRfQtUcUioXGNY6rLTR4PxhcaEmK5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aCsfligRbF9gZkPNMIuA7cziVFU6a8zmaBDG+cTssZHTjd1Pxy8nVavtCMeiwfuw/ AJUcIKVfudJMSOxkElKxRa+rGzYbozvUmmaNbGMPbopLfWOintVMFG2rhld0ra8ZGz UlIm3dF/CLOq6FsOeI7F0Nt4KKbGxRn8QjNLj7xw= Date: Wed, 8 Jul 2020 13:19:35 -0500 From: "Gustavo A. R. Silva" To: Ben Skeggs Cc: Ben Skeggs , David Airlie , Daniel Vetter , ML nouveau , LKML , ML dri-devel Subject: Re: [PATCH][next] drm/nouveau: Use fallthrough pseudo-keyword Message-ID: <20200708181935.GE11533@embeddedor> References: <20200707173628.GA29695@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08, 2020 at 01:22:35PM +1000, Ben Skeggs wrote: > On Wed, 8 Jul 2020 at 03:31, Gustavo A. R. Silva wrote: > > > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > > fall-through markings when it is the case. > I really like this! I was not a fan of explicitly marking those with comments. > :) > Thank you, taken in my tree. Thanks, Ben. -- Gustavo