From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D0DC433DF for ; Wed, 8 Jul 2020 19:34:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C68F720774 for ; Wed, 8 Jul 2020 19:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594236856; bh=trbpVxueRJhho0ntp4U+HjeFPyUeIcRU0OSyGcAoJPg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jH6WEbb9MCjno10kKwQmyhChUHa9b6M1uuI+tm4SGgEGlAQKh8foxEc90EGCEepqz myB/A0PShdvO8a1NHTTXpmTR5O4UYu79x/AFMamnZEAEmcgXjZdOPfyRgtCaMMfzM3 kiMoCCFsU90U8iCLDOmVJkYWP3Omi96ix2NnZmdw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbgGHTeP (ORCPT ); Wed, 8 Jul 2020 15:34:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:48822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgGHTeO (ORCPT ); Wed, 8 Jul 2020 15:34:14 -0400 Received: from embeddedor (unknown [201.162.240.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FB4220720; Wed, 8 Jul 2020 19:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594236854; bh=trbpVxueRJhho0ntp4U+HjeFPyUeIcRU0OSyGcAoJPg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qMWroq5v6pTfxB6LhBOnQArAQxz/wuA55yPp68otSILYyP/aP6gxFM7+oK/h939JA 4xzxrg2WLfAQ45stASiEVHiqDJ201/scLQQQFtsoGwzF2U+b/E7rLpundKwLHqynuO e5rkZsUTtQgitkxUNzn0Hbt3VPAXN/wl9UMAQZg4= Date: Wed, 8 Jul 2020 14:39:42 -0500 From: "Gustavo A. R. Silva" To: Stefan Haberland Cc: Jan Hoeppner , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH][next] s390/dasd: Use struct_size() helper Message-ID: <20200708193942.GJ11533@embeddedor> References: <20200619165600.GA8668@embeddedor> <47a86753-fd4d-9a7a-c808-5f387c872ab3@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47a86753-fd4d-9a7a-c808-5f387c872ab3@linux.ibm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08, 2020 at 11:13:08AM +0200, Stefan Haberland wrote: > Am 19.06.20 um 18:56 schrieb Gustavo A. R. Silva: > > Make use of the struct_size() helper instead of an open-coded version > > in order to avoid any potential type mistakes. Also, remove unnecessary > > variable _datasize_. > > > > This code was detected with the help of Coccinelle and, audited and > > fixed manually. > > > > Signed-off-by: Gustavo A. R. Silva > > Thanks for the patch. > Tested and applied. Thanks, Stefan. -- Gustavo