Re: [PATCH] platform/chrome: cros_ec_typec: USB4 support

[Prashant Malani <pmalani@chromium.org>]

Hi,

On Fri, Jul 03, 2020 at 11:17:03AM +0300, Heikki Krogerus wrote:
> +static int cros_typec_enable_usb4(struct cros_typec_data *typec,
> +				  int port_num,
> +				  struct ec_response_usb_pd_control_v2 *pd_ctrl)
> +{
> +	struct cros_typec_port *port = typec->ports[port_num];
> +	struct enter_usb_data data;
> +
> +
> +	/* REVISIT: Cable Current? */

Since we don't pull this data out of the EC currently, I think we can just drop
this for now (the "Mux" drivers aren't using this data at the moment
either).

> +
> +	/* REVISIT: Claiming unconditionally that all tunnels are supported. */
> +	data.eudo |= EUDO_PCIE_SUPPORT;
> +	data.eudo |= EUDO_DP_SUPPORT;
> +
> +	data.eudo |= EUDO_TBT_SUPPORT;
> +	data.eudo |= EUDO_HOST_PRESENT;

I think it's fine to drop this block altogether. I don't think any of
the current "Mux" drivers parse this information, and we aren't surfacing
it from the Chrome EC.

> +
>  	} else if (mux_flags & USB_PD_MUX_DP_ENABLED) {
>  		ret = cros_typec_enable_dp(typec, port_num, pd_ctrl);
> -- 
> 2.27.0
> 

I'll wait for a day for any comments for the maintainers, and if not,
I'll upload v2 of this patch with the "REVISIT" comments omitted.

Thanks,

-Prashant