From: Steven Rostedt <rostedt@goodmis.org>
To: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] tracing: simplify the logic by defining next to be "lasst + 1"
Date: Thu, 9 Jul 2020 17:59:19 -0400 [thread overview]
Message-ID: <20200709175919.1a459e06@oasis.local.home> (raw)
In-Reply-To: <20200703020612.12930-2-richard.weiyang@linux.alibaba.com>
On Fri, 3 Jul 2020 10:06:09 +0800
Wei Yang <richard.weiyang@linux.alibaba.com> wrote:
> The value to be used and compared in trace_search_list() is "last + 1".
> Let's just define next to be "last + 1" instead of doing the addition
> each time.
Yeah, this is a nice clean up. I'll take this one.
-- Steve
>
> Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
> ---
> kernel/trace/trace_output.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> index 47bf9f042b97..b704b3ef4264 100644
> --- a/kernel/trace/trace_output.c
> +++ b/kernel/trace/trace_output.c
> @@ -675,11 +675,11 @@ static LIST_HEAD(ftrace_event_list);
> static int trace_search_list(struct list_head **list)
> {
> struct trace_event *e;
> - int last = __TRACE_LAST_TYPE;
> + int next = __TRACE_LAST_TYPE + 1;
>
> if (list_empty(&ftrace_event_list)) {
> *list = &ftrace_event_list;
> - return last + 1;
> + return next;
> }
>
> /*
> @@ -687,17 +687,17 @@ static int trace_search_list(struct list_head **list)
> * lets see if somebody freed one.
> */
> list_for_each_entry(e, &ftrace_event_list, list) {
> - if (e->type != last + 1)
> + if (e->type != next)
> break;
> - last++;
> + next++;
> }
>
> /* Did we used up all 65 thousand events??? */
> - if ((last + 1) > TRACE_EVENT_TYPE_MAX)
> + if (next > TRACE_EVENT_TYPE_MAX)
> return 0;
>
> *list = &e->list;
> - return last + 1;
> + return next;
> }
>
> void trace_event_read_lock(void)
next prev parent reply other threads:[~2020-07-09 21:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 2:06 [PATCH 1/5] tracing: use union to simplify the trace_event_functions initialization Wei Yang
2020-07-03 2:06 ` [PATCH 2/5] tracing: simplify the logic by defining next to be "lasst + 1" Wei Yang
2020-07-09 21:59 ` Steven Rostedt [this message]
2020-07-03 2:06 ` [PATCH 3/5] tracing: save one trace_event->type by using __TRACE_LAST_TYPE Wei Yang
2020-07-09 22:04 ` Steven Rostedt
2020-07-03 2:06 ` [PATCH 4/5] tracing: use NULL directly to create root level tracefs Wei Yang
2020-07-03 2:06 ` [PATCH 5/5] tracing: toplevel d_entry already initialized Wei Yang
2020-07-09 22:13 ` Steven Rostedt
2020-07-10 1:11 ` Wei Yang
2020-07-10 13:08 ` Steven Rostedt
2020-07-09 21:57 ` [PATCH 1/5] tracing: use union to simplify the trace_event_functions initialization Steven Rostedt
2020-07-10 1:10 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709175919.1a459e06@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard.weiyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox