From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6553C433DF for ; Fri, 10 Jul 2020 00:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 923EE2073A for ; Fri, 10 Jul 2020 00:52:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BFP8tF2H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbgGJAwg (ORCPT ); Thu, 9 Jul 2020 20:52:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbgGJAwg (ORCPT ); Thu, 9 Jul 2020 20:52:36 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A5AC08C5DC for ; Thu, 9 Jul 2020 17:52:36 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id w2so1729587pgg.10 for ; Thu, 09 Jul 2020 17:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8yPHrCXyBLOpR6zGRIWiDtKHwiJWpvvhg1ayG2n9fc8=; b=BFP8tF2HhYiKA/qyJjHegpvIsVSUuEje6azN5GY0R3L8WUoBLc3wHtzR+46I4fEuPk XfiUAO8rReB0liW6wBmI3p2UY8xt/niNaytXTXJB+c3gWeaM5uKjATHL5zaongbYrilm Ztasc8EgPA+Q1kqS5vkNpKLsqai7o8NQCrLkI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8yPHrCXyBLOpR6zGRIWiDtKHwiJWpvvhg1ayG2n9fc8=; b=I7YSpZmdmr2USD04dv6QweHNL6CXAmoYFfxnJqXKyTrQKXPEJRqs8oucrwn1SsOaEL s9QfOagrTi+QTbetEQniniO1VFqTyuTXakBhKRJ/GSQhyPHi5BY3C2eSVIyVvKhyB2T/ A2QF6G8IOL5eJelXR5T1hkpb8v4XliGV1ouIqfQ1jIgq+2SU6+pRlGfPZGXSFGF4JAkE nO3p410BPfgp7SEWkx9PUjXpyxyfK5wvLv+hkWVgKAcQfxVl7RoFH10gy1W9ogBoee1T QvD2Vm3kIU5gWRnkiID+DT57LTZDaOipOPpQxYDaRIRAnKrhogLEPximGVDwEO8Avem5 XD7g== X-Gm-Message-State: AOAM533GCMnGG4PumHGo0lqttRtP+i0fGQ0yY16JpETXjh1g0jhev9B9 STsS9O/nHPMYb8t+FVny8PT0NQ== X-Google-Smtp-Source: ABdhPJwcYWeG5bs4YVaoD0/XoNI2VB/2PQjL7qAGKEGMFaiXaUld/StQmsEVPMcCxV9DXDcYFi7yBw== X-Received: by 2002:a62:1716:: with SMTP id 22mr56845258pfx.99.1594342355674; Thu, 09 Jul 2020 17:52:35 -0700 (PDT) Received: from localhost ([2620:15c:202:1:f693:9fff:fef4:e70a]) by smtp.gmail.com with ESMTPSA id v28sm3992962pgn.81.2020.07.09.17.52.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2020 17:52:34 -0700 (PDT) Date: Thu, 9 Jul 2020 17:52:33 -0700 From: Matthias Kaehlcke To: Veerabhadrarao Badiganti Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, bjorn.andersson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross Subject: Re: [PATCH V1] mmc: sdhci-msm: Set IO pins in low power state during suspend Message-ID: <20200710005233.GN3191083@google.com> References: <1594213888-2780-1-git-send-email-vbadigan@codeaurora.org> <1594213888-2780-2-git-send-email-vbadigan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1594213888-2780-2-git-send-email-vbadigan@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jul 08, 2020 at 06:41:20PM +0530, Veerabhadrarao Badiganti wrote: > Configure SDHC IO pins with low power configuration when the driver > is in suspend state. > > Signed-off-by: Veerabhadrarao Badiganti > --- > drivers/mmc/host/sdhci-msm.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 392d41d57a6e..efd2bae1430c 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > #include "sdhci-pltfm.h" > #include "cqhci.h" > @@ -1352,6 +1353,19 @@ static void sdhci_msm_set_uhs_signaling(struct sdhci_host *host, > sdhci_msm_hs400(host, &mmc->ios); > } > > +static int sdhci_msm_set_pincfg(struct sdhci_msm_host *msm_host, bool level) > +{ > + struct platform_device *pdev = msm_host->pdev; > + int ret; > + > + if (level) > + ret = pinctrl_pm_select_default_state(&pdev->dev); > + else > + ret = pinctrl_pm_select_sleep_state(&pdev->dev); > + > + return ret; > +} > + > static int sdhci_msm_set_vmmc(struct mmc_host *mmc) > { > if (IS_ERR(mmc->supply.vmmc)) > @@ -1596,6 +1610,9 @@ static void sdhci_msm_handle_pwr_irq(struct sdhci_host *host, int irq) > ret = sdhci_msm_set_vqmmc(msm_host, mmc, > pwr_state & REQ_BUS_ON); > if (!ret) > + ret = sdhci_msm_set_pincfg(msm_host, > + pwr_state & REQ_BUS_ON); > + if (!ret) > irq_ack |= CORE_PWRCTL_BUS_SUCCESS; > else > irq_ack |= CORE_PWRCTL_BUS_FAIL; I happened to have a debug patch in my tree which logs when regulators are enabled/disabled, with this patch I see the SD card regulator toggling constantly after returning from the first system suspend. I added more logs: [ 1156.085819] DBG: sdhci_msm_set_pincfg: level = 0 (ret: 0) [ 1156.248936] DBG: sdhci_msm_set_pincfg: level = 1 (ret: 0) [ 1156.301989] DBG: sdhci_msm_set_pincfg: level = 0 (ret: 0) [ 1156.462383] DBG: sdhci_msm_set_pincfg: level = 1 (ret: 0) [ 1156.525988] DBG: sdhci_msm_set_pincfg: level = 0 (ret: 0) [ 1156.670372] DBG: sdhci_msm_set_pincfg: level = 1 (ret: 0) [ 1156.717935] DBG: sdhci_msm_set_pincfg: level = 0 (ret: 0) [ 1156.878122] DBG: sdhci_msm_set_pincfg: level = 1 (ret: 0) [ 1156.928134] DBG: sdhci_msm_set_pincfg: level = 0 (ret: 0) This is on an SC7180 platform. It doesn't run an upstream kernel though, but v5.4 with plenty of upstream patches.