Re: [PATCH 2/2] ARM: dts: exynos: Remove interrupts from DMC controller in Exynos5422

Lukasz Luba
2020-08-24T11:38:00Z

On 8/21/20 7:32 AM, Krzysztof Kozlowski wrote:
> On Fri, 21 Aug 2020 at 08:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Mon, 17 Aug 2020 at 19:17, Lukasz Luba <lukasz.luba@arm.com> wrote:
>>>
>>> Hi Krzysztof,
>>>
>>> On 8/17/20 4:50 PM, Krzysztof Kozlowski wrote:
>>>> On Wed, Jul 08, 2020 at 04:34:20PM +0100, Lukasz Luba wrote:
>>>>> The interrupts in Dynamic Memory Controller in Exynos5422 and Odroid
>>>>> XU3-family boards are no longer needed. They have been used in order
>>>>> to workaround some issues in scheduled work in devfreq. Now when the
>>>>> devfreq framework design is improved, remove the interrupt driven
>>>>> approach and rely on devfreq monitoring mechanism with fixed intervals.
>>>>>
>>>>> Reported-by: Willy Wolff <willy.mh.wolff.ml@gmail.com>
>>>>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>>>>> ---
>>>>> arch/arm/boot/dts/exynos5420.dtsi | 3 ---
>>>>> 1 file changed, 3 deletions(-)
>>>>
>>>> I think the dependencies were merged so this can be safely applied
>>>> without bisectability problems?
>>>
>>> I have created v2 of that fix and it got merged
>>> via Chanwoo's tree, the commit 4fc9a0470d2dc37028
>>> https://lkml.org/lkml/2020/7/10/1048
>>>
>>> That commit switched the driver default mode from 'irq driven' to
>>> new devfreq monitoring mechanism. Furthermore, when the driver is
>>> built as a module, you can try to use the 'irq mode', but for this
>>> you would need the DT IRQs description (this $subject tries to remove).
>>>
>>> I would like to keep this IRQ mode for experimentation, as I
>>> described in answers to Bartek's questions:
>>> https://lkml.org/lkml/2020/7/14/315
>>>
>>> Unfortunately, I am quite busy and won't make any progress before the
>>> LPC.
>>
>> None of these were the actual answer to my question, unless by "v2 of
>> that fix and it got merged" means the dependencies?
>>
>> I'll drop it from the queue. Please resend if it is valid.
>
> Agh, not drop, I mean postpone for the next cycle (this is v5.11).
>

Fair enough

Regards,
Lukasz