From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1] regmap: Switch to use fwnode instead of OF one
Date: Fri, 10 Jul 2020 17:22:20 +0100 [thread overview]
Message-ID: <20200710162220.GG5653@sirena.org.uk> (raw)
In-Reply-To: <CAHp75VeWmWU6=ybDmQmv7ymwaHG+FxNBzZM9eBxp2Oie6MrZQw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Fri, Jul 10, 2020 at 05:13:06PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 10, 2020 at 4:36 PM Mark Brown <broonie@kernel.org> wrote:
> > Oh, I see your patch covered a different bit of code without covering
> > the stuff in regmap-irq (which I'd just handled when your patch came in)
> > for some reason so the changelog made it sound like the same code, and
> > at the time you submitted it the patch was incomplete.
> Should I do anything to improve it?
Ideally the changelog should have been more clear that it was a partial
conversion (and which bits of the code it was covering), that'd have
made it more obvious that it was covering more/different stuff to the
other patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-10 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 16:12 [PATCH v1] regmap: Switch to use fwnode instead of OF one Andy Shevchenko
2020-07-08 16:21 ` Mark Brown
2020-07-10 10:05 ` Andy Shevchenko
2020-07-10 11:01 ` Mark Brown
2020-07-10 11:46 ` Andy Shevchenko
2020-07-10 12:08 ` Mark Brown
2020-07-10 13:32 ` Mark Brown
2020-07-10 14:13 ` Andy Shevchenko
2020-07-10 14:15 ` Andy Shevchenko
2020-07-10 14:35 ` Andy Shevchenko
2020-07-10 16:22 ` Mark Brown [this message]
2020-07-10 14:11 ` Andy Shevchenko
2020-07-10 15:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710162220.GG5653@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox