From: Dejin Zheng <zhengdejin5@gmail.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Rob Herring <robh@kernel.org>,
"Chocron, Jonathan" <jonnyc@amazon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v1] PCI: controller: Remove duplicate error message
Date: Sat, 11 Jul 2020 15:47:33 +0800 [thread overview]
Message-ID: <20200711074733.GD3112@nuc8i5> (raw)
In-Reply-To: <20200706155847.GA32050@e121166-lin.cambridge.arm.com>
On Mon, Jul 06, 2020 at 04:58:47PM +0100, Lorenzo Pieralisi wrote:
> On Tue, Jun 02, 2020 at 09:01:13AM -0600, Rob Herring wrote:
>
> [...]
>
> > > The other 2 error cases as well don't print the resource name as far as
> > > I recall (they will at least print the resource start/end).
> >
> > Start/end are what are important for why either of these functions
> > failed.
> >
> > But sure, we could add 'name' here. That's a separate patch IMO.
Hi Lorenzo, Bob and Jonathan:
Thank you very much for helping me review this patch, I sent a new patch
for print the resource name when the request memory region or remapping
of configuration space fails. and it is here:
https://patchwork.kernel.org/patch/11657801/
BR,
Dejin
>
> I agree. In sum, I think it is OK to proceed with this patch, provided
> we send follow-ups as discussed here, are we in agreement ?
>
> Lorenzo
next prev parent reply other threads:[~2020-07-11 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 15:09 [PATCH v1] PCI: controller: Remove duplicate error message Dejin Zheng
2020-05-26 18:22 ` Chocron, Jonathan
2020-05-27 13:20 ` Dejin Zheng
2020-06-02 7:44 ` Chocron, Jonathan
2020-06-02 15:01 ` Rob Herring
2020-07-06 15:58 ` Lorenzo Pieralisi
2020-07-11 7:47 ` Dejin Zheng [this message]
2020-07-15 16:45 ` Lorenzo Pieralisi
2020-07-17 13:44 ` Dejin Zheng
2020-06-01 22:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711074733.GD3112@nuc8i5 \
--to=zhengdejin5@gmail.com \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox