From: Shawn Guo <shawnguo@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6qdl: only enable pcie in the pcie dts file
Date: Mon, 13 Jul 2020 14:48:52 +0800 [thread overview]
Message-ID: <20200713064851.GH12113@dragon> (raw)
In-Reply-To: <1594025081-2353-1-git-send-email-hongxing.zhu@nxp.com>
On Mon, Jul 06, 2020 at 04:44:41PM +0800, Richard Zhu wrote:
> Since iMX6Q/DL PCIe has the PM limitation (ERR005723 "PCIe PCIe does
> not support L2 Power Down").
> System suspend/resume would be broken by PCIe, if PCIe is enabled.
> Only enable PCIe in the xxx-pcie.dts files to avoid the brokens when
> other xxx.dtb files are used on sabresd and sabreauto boards.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> arch/arm/boot/dts/Makefile | 4 ++++
> arch/arm/boot/dts/imx6dl-sabreauto-pcie.dts | 12 ++++++++++++
> arch/arm/boot/dts/imx6dl-sabresd-pcie.dts | 12 ++++++++++++
> arch/arm/boot/dts/imx6q-sabreauto-pcie.dts | 12 ++++++++++++
> arch/arm/boot/dts/imx6q-sabresd-pcie.dts | 12 ++++++++++++
> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 4 ----
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 -
> 7 files changed, 52 insertions(+), 5 deletions(-)
> create mode 100644 arch/arm/boot/dts/imx6dl-sabreauto-pcie.dts
> create mode 100644 arch/arm/boot/dts/imx6dl-sabresd-pcie.dts
> create mode 100644 arch/arm/boot/dts/imx6q-sabreauto-pcie.dts
> create mode 100644 arch/arm/boot/dts/imx6q-sabresd-pcie.dts
No. There are hundreds of boards based on i.MX6Q/DL. We are not going
to maintain a -pcie.dts for every single one of them.
Shawn
prev parent reply other threads:[~2020-07-13 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 8:44 [PATCH] ARM: dts: imx6qdl: only enable pcie in the pcie dts file Richard Zhu
2020-07-08 17:48 ` Fabio Estevam
2020-07-09 2:39 ` [EXT] " Richard Zhu
2020-07-13 6:48 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713064851.GH12113@dragon \
--to=shawnguo@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox