Re: [RFC PATCH 02/35] ssb: Change PCIBIOS_SUCCESSFUL to 0

Larry Finger
2020-07-13T18:35:47Z

On 7/13/20 2:13 PM, Saheed Bolarinwa wrote:
> Hello Larry,
>
> On 7/13/20 7:16 PM, Larry Finger wrote:
>> On 7/13/20 7:22 AM, Saheed O. Bolarinwa wrote:
>>> In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept.
>>> Their scope should be limited within arch/x86.
>>>
>>> Change all PCIBIOS_SUCCESSFUL to 0
>>>
>>> Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com>
>>
>> Could you please tell me what difference this makes? It looks like source
>> churn rather than a substantive change. The symbol is defined in pci.h and is
>> used in many architures. Certainly, PCIBIOS_SUCCESSFUL indicates success even
>> more clearly than 0 does.
>>
> It is a trivial first step towards a probably significant task. I explained in
> the Cover Letter, I can see it didn't get through but I Cc linux-wireless
> (properly this time). Probably, too many addresses.
>
> I have resent it. It is here
> https://lore.kernel.org/linux-wireless/20200713185559.31967-1-refactormyself@gmail.com/T/#u
>
>
>> Why is your name inside quotes in your s-o-b?
>>
> To keep me company before I get to know my way within the kernel.
>
> I saw people with >2 names do it, so I did! Please let me know if it is odd.
>

Thank you for the explanations. The cover letter did help.

For both SSB and BMCA changes,

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry