Re: [RFC PATCH 02/35] ssb: Change PCIBIOS_SUCCESSFUL to 0

Larry Finger
2020-07-13T17:16:26Z

On 7/13/20 7:22 AM, Saheed O. Bolarinwa wrote:
> In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept.
> Their scope should be limited within arch/x86.
>
> Change all PCIBIOS_SUCCESSFUL to 0
>
> Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com>

Could you please tell me what difference this makes? It looks like source churn
rather than a substantive change. The symbol is defined in pci.h and is used in
many architures. Certainly, PCIBIOS_SUCCESSFUL indicates success even more
clearly than 0 does.

Why is your name inside quotes in your s-o-b?

Larry