From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Rishabh Bhatnagar <rishabhb@codeaurora.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] remoteproc: qcom: Add missing slab.h
Date: Mon, 13 Jul 2020 12:01:06 -0700 [thread overview]
Message-ID: <20200713190106.GA2161373@builder.lan> (raw)
In-Reply-To: <20200713020003.134039-1-wangkefeng.wang@huawei.com>
On Sun 12 Jul 19:00 PDT 2020, Kefeng Wang wrote:
> drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’:
> drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’?
> [-Werror=implicit-function-declaration]
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> ^~~~~~~
> vzalloc
>
> kzalloc() is declared in linux/slab.h, add include to fix build issue.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Thank Kefeng, patch applied.
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
> index 2f45f0c79914e..085fd73fa23ae 100644
> --- a/drivers/remoteproc/qcom_common.c
> +++ b/drivers/remoteproc/qcom_common.c
> @@ -15,6 +15,7 @@
> #include <linux/remoteproc/qcom_rproc.h>
> #include <linux/rpmsg/qcom_glink.h>
> #include <linux/rpmsg/qcom_smd.h>
> +#include <linux/slab.h>
> #include <linux/soc/qcom/mdt_loader.h>
>
> #include "remoteproc_internal.h"
> --
> 2.26.2
>
prev parent reply other threads:[~2020-07-13 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 2:00 [PATCH -next] remoteproc: qcom: Add missing slab.h Kefeng Wang
2020-07-13 18:55 ` Alex Elder
2020-07-13 19:01 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713190106.GA2161373@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=rishabhb@codeaurora.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).