From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Gutson <daniel@eclypsium.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Hughes <hughsient@gmail.com>,
Alex Bazhaniuk <alex@eclypsium.com>
Subject: Re: [PATCH] SPI LPC information kernel module
Date: Tue, 14 Jul 2020 08:38:20 +0200 [thread overview]
Message-ID: <20200714063820.GD662760@kroah.com> (raw)
In-Reply-To: <CAFmMkTGkmBgmv6wmS1kNWxGm0ktN56u9pJVJQKyPvLipyHsgqw@mail.gmail.com>
On Mon, Jul 13, 2020 at 07:24:11PM -0300, Daniel Gutson wrote:
> On Mon, Jul 6, 2020 at 6:54 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Mon, Jul 6, 2020 at 11:20 AM Arnd Bergmann <arnd@arndb.de> wrote:
> > >
> > > > Because of these reasons, I'm proposing a misc (not-device) driver
> > that supports
> > > > many Intel architectures (and families) to expose the information.
> > > > I understand your proposal to first enhance existing _device_ drivers,
> > but I
> > > > couldn't find suitable options.
> > >
> > > Maybe try adding an interface to one of the drivers at first, and then
> > extend
> > > it to the other hardware after an initial code review. Do not bypass the
> > driver
> > > model or try to do everything at once with a single module that knows
> > > details of multiple unrelated hardware implementations.
> >
> > To clarify further how I think you can have a chance of getting the
> > interface you want, here's a step-by-step list:
> >
> > 1. keep the current securityfs interface (or any other user space
> > ABI if you have already changed it), but put it into a separate loadable
> > module
>
>
> If it is a loadable module, how can I ensure that it was loaded before the
> intel-spi driver, so the latter can call
> the API of the former? What if the driver was not loaded, when the
> intel-spi driver will try to call
> your suggested spi_lpc_register_info? In other words, how can I prevent to
> call functions from an unloaded driver?
THe symbol will not be resolved so the module will not be able to be
loaded in the first place, OR your module will be loaded first by the
system to prevent that.
> Do I just add the dependency in the Kconfig? But if so, what about the
> order of initialization?
> A hint please?
Try it and see what happens, it should all "just work" :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-14 6:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 22:59 [PATCH] SPI LPC information kernel module Daniel Gutson
2020-06-30 8:02 ` kernel test robot
2020-06-30 8:56 ` Greg Kroah-Hartman
2020-06-30 13:57 ` Richard Hughes
2020-06-30 14:24 ` Arnd Bergmann
2020-06-30 15:14 ` Greg Kroah-Hartman
[not found] ` <CAFmMkTGrnZt7ZaGyYCe-LCHET4yHz9DfanaZwsOS6HCxK40apQ@mail.gmail.com>
2020-06-30 15:00 ` Arnd Bergmann
2020-06-30 15:28 ` Greg Kroah-Hartman
2020-06-30 15:32 ` Greg Kroah-Hartman
[not found] ` <CAFmMkTGy7u8oNSPmBHf9+URzKeNOxy5TJtqF3FCruRkTgJ_wGQ@mail.gmail.com>
2020-06-30 16:55 ` Greg Kroah-Hartman
2020-06-30 8:58 ` Arnd Bergmann
[not found] ` <CAFmMkTHrQ4LZk4+-3kdJ+dc47MXR1Jd76AXbO-ceT2zsfDRFGQ@mail.gmail.com>
2020-06-30 20:57 ` Arnd Bergmann
[not found] ` <CAFmMkTE3z6OZQ_v3jx-4MzMr8v+4qcF2uLn0ASGydj5oqDnfjg@mail.gmail.com>
2020-07-06 9:20 ` Arnd Bergmann
2020-07-06 9:54 ` Arnd Bergmann
[not found] ` <CAFmMkTGkmBgmv6wmS1kNWxGm0ktN56u9pJVJQKyPvLipyHsgqw@mail.gmail.com>
2020-07-14 6:38 ` Greg Kroah-Hartman [this message]
2020-07-06 10:22 ` Arnd Bergmann
2020-06-30 8:58 ` Greg Kroah-Hartman
2020-06-30 8:59 ` Greg Kroah-Hartman
2020-06-30 9:00 ` Greg Kroah-Hartman
2020-07-01 7:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714063820.GD662760@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex@eclypsium.com \
--cc=arnd@arndb.de \
--cc=daniel@eclypsium.com \
--cc=derek.kiernan@xilinx.com \
--cc=hughsient@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox