From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] hpilo: Replace one-element array with flexible-array member
Date: Tue, 14 Jul 2020 13:06:11 -0500 [thread overview]
Message-ID: <20200714180611.GA30749@embeddedor> (raw)
In-Reply-To: <20200714161948.GA2092551@kroah.com>
On Tue, Jul 14, 2020 at 06:19:48PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 14, 2020 at 10:44:49AM -0500, Gustavo A. R. Silva wrote:
> > There is a regular need in the kernel to provide a way to declare
> > having a dynamically sized set of trailing elements in a structure.
> > Kernel code should always use “flexible array members”[1] for these
> > cases. The older style of one-element or zero-length arrays should
> > no longer be used[2].
> >
> > For this particular case, it is important to notice that the cachelines
> > change from 7 to 6 after the flexible-array conversion:
>
> That's really funny to see. Nice work, I'll go queue this up. I doubt
> anyone will notice as this is a very old driver :)
>
Yep; by the way, notice the link to the Kernel CI test results:
https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/kernel-ci/hpilo-20200714.md
I plan to add the generation --and inclusion in the changelog text-- of
such links to my workflow, whenever possible.
When Kernel CI reports 'SUCCESS', they don't send the report to any mailing
list; they only send those reports to the maintainers/developers. So. I'm
going to store the ones I get in this github repository:
https://github.com/GustavoARSilva/linux-hardening/tree/master/cii/kernel-ci/
Thanks
--
Gustavo
prev parent reply other threads:[~2020-07-14 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 15:44 [PATCH][next] hpilo: Replace one-element array with flexible-array member Gustavo A. R. Silva
2020-07-14 16:19 ` Greg Kroah-Hartman
2020-07-14 18:06 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714180611.GA30749@embeddedor \
--to=gustavoars@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox