Re: [PATCH v4 29/75] x86/idt: Move two function from k/idt.c to i/a/desc.h

Kees Cook
2020-07-15T01:29:31Z

On Tue, Jul 14, 2020 at 02:08:31PM +0200, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>

I'm not a huge fan of the Subject. :) Maybe:

x86/idt: Make IDT init functions static inlines

>
> Move these two functions from kernel/idt.c to include/asm/desc.h:
>
> * init_idt_data()
> * idt_init_desc()
>
> These functions are needed to setup IDT entries very early and need to
> be called from head64.c. To be usable this early these functions need to
> be compiled without instrumentation and the stack-protector feature.
> These features need to be kept enabled for kernel/idt.c, so head64.c
> must use its own versions.
>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>

But regardless:

Reviewed-by: Kees Cook <keescook@chromium.org>

--
Kees Cook