From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879B2C433E0 for ; Wed, 15 Jul 2020 06:47:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 620A420663 for ; Wed, 15 Jul 2020 06:47:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ycVggVFo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728847AbgGOGrU (ORCPT ); Wed, 15 Jul 2020 02:47:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728650AbgGOGrT (ORCPT ); Wed, 15 Jul 2020 02:47:19 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97160C061755 for ; Tue, 14 Jul 2020 23:47:19 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id o11so1163717wrv.9 for ; Tue, 14 Jul 2020 23:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RZua3L7ORYc/5yUTlbkpDQCk3pb0Hn/UmvH2O1LP5AI=; b=ycVggVFoo6iBM+WvMNC2erRI9VWkQ3uaqCbF2FKH68DO8rPcaAcXiE2qqS4E1N2xtv ygG7TcXaU16EgP6eun5Ezs28IfNyjcihAsjXca4TBLPJ8iuVHbX3NWFi54yXJ6lWZf13 a1HYlLNDv1IWnh8YXyt/G/8PAKiz5Gheg6/04cL+tKh3rlz/VouvO1IWuW1mZSMf/g/V +FhNs5U4qAtD2z2J9lQzSsRMeFqwLLJwvJZgcAy5tnyDU8of9oWvKiz2j3IxI7p6nvkO afB4OYlF210oK1fWU66gwAoiOZPZTg+ynQXki+DwQ46cAsufP2Rtjo9Znbc2XH888z+S awNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RZua3L7ORYc/5yUTlbkpDQCk3pb0Hn/UmvH2O1LP5AI=; b=Nl0yYE+jjUGQuSoz4k7XU2bwQ1ti0YIKvitFXSSA7/nRdgpLPW4b98y0LLUeYrm5N3 5u9KciprW4NULD5iXDrsLNOkFSbV0AeP5IPlXFPVN+ehBdIxNOYO/6dszcfdG5xgIIjq SdmZVVSpL/lqnJun914XRX2ktkZy6T0JFVmlLHDKVoP12i3WTcyf+ly2YEN18XhIvHtv RH/NHdxI4eagV6TfNuSvOtZy07z4cCEyngxgLQJdc5iIxGEIIWflt+mw1UBV7j9yN41E HN/c6HHfl9P0lg6PgUS0imS7Wj8ccCytXHcy8TiMkVzpErTG9tylHr4yWz2h8kgxoTFC WwCg== X-Gm-Message-State: AOAM5303xgN4mpD5jjmBK4r6/4SAAHzfZGJ8j7KBE59WxPeqYpg0He08 h1AQFj9mffSxXU2c03w4ept4iw== X-Google-Smtp-Source: ABdhPJwL5CBSF/GH6b4IIcV8l9IUoX2Ms8UjECSbuxp10q/Zf7L2cyBkfhgyHbrG9cgcuOUEctEs0w== X-Received: by 2002:adf:b190:: with SMTP id q16mr9739722wra.356.1594795638330; Tue, 14 Jul 2020 23:47:18 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id u20sm1905445wmm.15.2020.07.14.23.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 23:47:17 -0700 (PDT) Date: Wed, 15 Jul 2020 07:47:16 +0100 From: Lee Jones To: Viresh Kumar Cc: rjw@rjwysocki.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Dominik Brodowski , Ashok Raj , Jacob Shin Subject: Re: [PATCH 02/13] cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status Message-ID: <20200715064716.GT1398296@dell> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-3-lee.jones@linaro.org> <20200715024951.zr36iuagany5ii56@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200715024951.zr36iuagany5ii56@vireshk-i7> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jul 2020, Viresh Kumar wrote: > On 14-07-20, 15:50, Lee Jones wrote: > > -/** > > +/* > > * cpufreq_remove_dev - remove a CPU device > > Because cpufreq_add_dev() is part of kernel doc, we better keep it. > > > * > > * Removes the cpufreq interface for a CPU device. > > @@ -2373,6 +2374,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor); > > * cpufreq_get_policy - get the current cpufreq_policy > > * @policy: struct cpufreq_policy into which the current cpufreq_policy > > * is written > > + * @cpu: CPU to find the policy for > > * > > * Reads the current cpufreq policy. > > */ > > @@ -2759,7 +2761,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) > > } > > EXPORT_SYMBOL_GPL(cpufreq_register_driver); > > > > -/** > > +/* > > * cpufreq_unregister_driver - unregister the current CPUFreq driver > > And this should be there for sure. Where is the *.rst file that references this kerneldoc entry? Also, what do you mean by "there"? We're not removing the function header. It's still documented, it's just not kerneldoc. > > * > > * Unregister the current CPUFreq driver. Only call this if you have > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog