From: Kees Cook <keescook@chromium.org>
To: David Gow <davidgow@google.com>
Cc: Vitor Massaru Iha <vitor@massaru.org>,
KUnit Development <kunit-dev@googlegroups.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brendan Higgins <brendanhiggins@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [RFC 0/3] kunit: add support to use modules
Date: Wed, 15 Jul 2020 19:41:41 -0700 [thread overview]
Message-ID: <202007151939.62EFE6F@keescook> (raw)
In-Reply-To: <CABVgOSkBAiMSMzCx62_CRo_0e2SGdvRWZ0dSC4t628YJBw-3Aw@mail.gmail.com>
On Wed, Jul 15, 2020 at 11:47:11AM +0800, David Gow wrote:
> - The inheriting of the mm stuff still means that
> copy_{from,to}_user() will only work if loaded as a module. This
> really needs to be documented. (Ideally, we'd find a way of having
> this work even for built-in tests, but I don't have any real ideas as
> to how that could be done).
I'd like to better understand this ... are there conditions where
vm_mmap() doesn't work? I thought this would either use current() (e.g.
how LKDTM uses it when getting triggered from debugfs), or use init_mm.
I'd really like to see the mm patch more well described/justified.
--
Kees Cook
next prev parent reply other threads:[~2020-07-16 2:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 3:11 [RFC 0/3] kunit: add support to use modules Vitor Massaru Iha
2020-07-15 3:11 ` [RFC 1/3] kunit: tool: Add support root filesystem in kunit-tool Vitor Massaru Iha
2020-07-16 0:29 ` Brendan Higgins
2020-07-16 16:34 ` Vitor Massaru Iha
2020-07-15 3:11 ` [RFC 2/3] lib: Allows to borrow mm in userspace on KUnit Vitor Massaru Iha
2020-07-16 0:37 ` Brendan Higgins
2020-07-16 16:35 ` Vitor Massaru Iha
2020-07-16 16:35 ` Vitor Massaru Iha
2020-07-15 3:11 ` [RFC 3/3] lib: Convert test_user_copy to KUnit test Vitor Massaru Iha
2020-07-16 0:40 ` Brendan Higgins
2020-07-16 16:40 ` Vitor Massaru Iha
2020-07-16 2:34 ` Kees Cook
2020-07-16 16:42 ` Vitor Massaru Iha
2020-07-15 3:47 ` [RFC 0/3] kunit: add support to use modules David Gow
2020-07-16 2:41 ` Kees Cook [this message]
2020-07-16 16:32 ` Vitor Massaru Iha
2020-07-16 16:21 ` Vitor Massaru Iha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007151939.62EFE6F@keescook \
--to=keescook@chromium.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox