public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ondrej Jirman <megous@megous.com>
To: "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Robert Chiras" <robert.chiras@nxp.com>
Cc: Ondrej Jirman <megous@megous.com>,
	Samuel Holland <samuel@sholland.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Fix st7703 panel initialization failures
Date: Thu, 16 Jul 2020 14:37:51 +0200	[thread overview]
Message-ID: <20200716123753.3552425-1-megous@megous.com> (raw)

When extending the driver for xbd599 panel support I tried to do minimal
changes and keep the existing initialization timing.

It turned out that it's not good enough and the existing init sequence
is too aggressive and doesn't follow the specification. On PinePhone
panel is being powered down/up during suspend/resume and with current
timings this frequently leads to corrupted display.

This patch series fixes the problems.

The issue was reported by Samuel Holland.

Relevant screenshots from the datasheet:

  Power on timing: https://megous.com/dl/tmp/35b72e674ce0ca27.png
  Power off timing: https://megous.com/dl/tmp/dea195517106ff17.png
  More optimal reset on poweron: https://megous.com/dl/tmp/a9e5caf14e1b0dc6.png
  Less optimal reset on poweron: https://megous.com/dl/tmp/246761039283c4cf.png
  Datasheet: https://megous.com/dl/tmp/ST7703_DS_v01_20160128.pdf

Please take a look.

thank you and regards,
  Ondrej Jirman

Ondrej Jirman (2):
  drm/panel: st7703: Make the sleep exit timing match the spec
  drm/panel: st7703: Fix the power up sequence of the panel

 drivers/gpu/drm/panel/panel-sitronix-st7703.c | 29 ++++++++++---------
 1 file changed, 15 insertions(+), 14 deletions(-)

-- 
2.27.0


             reply	other threads:[~2020-07-16 12:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 12:37 Ondrej Jirman [this message]
2020-07-16 12:37 ` [PATCH 1/2] drm/panel: st7703: Make the sleep exit timing match the spec Ondrej Jirman
2020-07-16 12:37 ` [PATCH 2/2] drm/panel: st7703: Fix the power up sequence of the panel Ondrej Jirman
2020-07-16 14:08 ` [PATCH 0/2] Fix st7703 panel initialization failures Guido Günther
2020-07-16 14:32   ` Ondřej Jirman
2020-07-18 17:31     ` Guido Günther
2020-07-18 17:42       ` Ondřej Jirman
2020-07-29 15:48         ` Guido Günther
2020-07-30 13:41           ` Ondřej Jirman
2020-08-01 11:04             ` Guido Günther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716123753.3552425-1-megous@megous.com \
    --to=megous@megous.com \
    --cc=agx@sigxcpu.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.chiras@nxp.com \
    --cc=sam@ravnborg.org \
    --cc=samuel@sholland.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox