From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0BA5C433E0 for ; Fri, 17 Jul 2020 06:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7FA222B48 for ; Fri, 17 Jul 2020 06:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594967331; bh=/zDpcXferlVtWyvGBk0RCp/EESwPvxFdFmaWT7IB5mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QaaJ/QIhnARaO5KBgur/U6sOej4ur/mBW5UKARHbipirxhXnAWWXAsc49TvzDpiL0 Fke1mNBucphE6HowNma2sZeljK/bf0CS9zX59r7yP2LmMiNjwUAD/nKb+5utgxyW27 9ISxVTj2L3ulSVhFJWNwPh9Wv/pPzw2Ntp+AUPX8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgGQG2u (ORCPT ); Fri, 17 Jul 2020 02:28:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:33200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgGQG2t (ORCPT ); Fri, 17 Jul 2020 02:28:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAD6E21744; Fri, 17 Jul 2020 06:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594967329; bh=/zDpcXferlVtWyvGBk0RCp/EESwPvxFdFmaWT7IB5mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mGn1qhG01OHqEEHQJUEmSuu/sVsHpdMBOUDRld0QlkpUsFb/3GgPZE0v1HXL4MOss SQafuUuYSS91Vd2p+yKKuMTKGVA0cE4/Jd5hrN52gyaFFA9lmL9DHqkXRZOmqzOh9l BXjcHxfLYZELw3WeZyuKI6/fdZ+kFeV4tMPKAcBI= Date: Fri, 17 Jul 2020 08:28:41 +0200 From: Greg Kroah-Hartman To: Daniel Gutson Cc: Derek Kiernan , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mika Westerberg , Arnd Bergmann , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Richard Hughes , Alex Bazhaniuk Subject: Re: [PATCH] [PATCH] Firmware security information in SYSFS Message-ID: <20200717062841.GA3238569@kroah.com> References: <20200716223627.253936-1-daniel.gutson@eclypsium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716223627.253936-1-daniel.gutson@eclypsium.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2020 at 07:36:27PM -0300, Daniel Gutson wrote: > +What: /sys/kernel/firmware-security/bioswe Ick, I stopped reading right here. No, this is not where this belongs. We already have /sys/firmware/, right? And firmware-specific subdirectories below that. We also have /sys/devices/system/ and I think that would be a much better place for this, as it is easier to work with a real 'struct device' than a "raw" kobject any day. Bonus is you get full support of userspace libraries when you do that, unlike when dealing with kobjects. Also, this really is a _SPECIFIC_ type of firmware that supports these features, right? Why not call that out too? This is not generic by any means. thanks, greg k-h