Re: [PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes

Zhang Rui
2020-07-28T13:16:59Z

On Fri, 2020-07-17 at 10:33 +0200, Jiri Olsa wrote:
> On Thu, Jul 16, 2020 at 11:18:57PM +0800, Zhang Rui wrote:
> > This fixes a problem introduced by
> > commit 5fb5273a905c ("perf/x86/rapl: Use new MSR detection
> > interface")
> > that perf event sysfs attributes for psys RAPL domain are missing.
> >
> > Fixes: 5fb5273a905c ("perf/x86/rapl: Use new MSR detection
> > interface")
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> > Reviewed-by: Len Brown <len.brown@intel.com>
> > ---
> > arch/x86/events/rapl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
> > index 0f2bf59f4354..51ff9a3618c9 100644
> > --- a/arch/x86/events/rapl.c
> > +++ b/arch/x86/events/rapl.c
> > @@ -665,7 +665,7 @@ static const struct attribute_group
> > *rapl_attr_update[] = {
> > &rapl_events_pkg_group,
> > &rapl_events_ram_group,
> > &rapl_events_gpu_group,
> > - &rapl_events_gpu_group,
> > + &rapl_events_psys_group,
>
> I did copy & paste but did not change to psys :-\
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Hi, jirka,

Thanks for your ACK.

Hi, Peter,

A gentle ping on this patch series.

thanks,
rui
>
> thanks,
> jirka
>
> > NULL,
> > };
> >
> > --
> > 2.17.1
> >
>
>