From: Changbin Du <changbin.du@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Changbin Du <changbin.du@gmail.com>
Subject: [PATCH v6 15/17] perf ftrace: add option -D/--delay to delay tracing
Date: Fri, 17 Jul 2020 22:36:26 +0800 [thread overview]
Message-ID: <20200717143628.47721-16-changbin.du@gmail.com> (raw)
In-Reply-To: <20200717143628.47721-1-changbin.du@gmail.com>
This adds an option '-D/--delay' to allow us to start tracing some
times later after workload is launched.
Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
tools/perf/Documentation/perf-ftrace.txt | 4 ++++
tools/perf/builtin-ftrace.c | 19 ++++++++++++++++---
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/tools/perf/Documentation/perf-ftrace.txt b/tools/perf/Documentation/perf-ftrace.txt
index 6f17939b8789..077249c979f2 100644
--- a/tools/perf/Documentation/perf-ftrace.txt
+++ b/tools/perf/Documentation/perf-ftrace.txt
@@ -38,6 +38,10 @@ OPTIONS
--pid=::
Trace on existing process id (comma separated list).
+-D::
+--delay::
+ Time (ms) to wait before starting tracing after program start.
+
-a::
--all-cpus::
Force system-wide collection. Scripts run without a <command>
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 3ddd7568b456..64b68331048a 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -47,6 +47,7 @@ struct perf_ftrace {
int graph_noirqs;
int graph_verbose;
int graph_thresh;
+ unsigned int initial_delay;
};
struct filter_entry {
@@ -594,13 +595,23 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
/* display column headers */
read_tracing_file_to_stdout("trace");
- if (write_tracing_file("tracing_on", "1") < 0) {
- pr_err("can't enable tracing\n");
- goto out_close_fd;
+ if (!ftrace->initial_delay) {
+ if (write_tracing_file("tracing_on", "1") < 0) {
+ pr_err("can't enable tracing\n");
+ goto out_close_fd;
+ }
}
perf_evlist__start_workload(ftrace->evlist);
+ if (ftrace->initial_delay) {
+ usleep(ftrace->initial_delay * 1000);
+ if (write_tracing_file("tracing_on", "1") < 0) {
+ pr_err("can't enable tracing\n");
+ goto out_close_fd;
+ }
+ }
+
while (!done) {
if (poll(&pollfd, 1, -1) < 0)
break;
@@ -809,6 +820,8 @@ int cmd_ftrace(int argc, const char **argv)
"size of per cpu buffer", parse_buffer_size),
OPT_BOOLEAN(0, "inherit", &ftrace.inherit,
"trace children processes"),
+ OPT_UINTEGER('D', "delay", &ftrace.initial_delay,
+ "ms to wait before starting tracing after program start"),
OPT_END()
};
--
2.25.1
next prev parent reply other threads:[~2020-07-17 14:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 14:36 [PATCH v6 00/17] perf: ftrace enhancement Changbin Du
2020-07-17 14:36 ` [PATCH v6 01/17] perf ftrace: select function/function_graph tracer automatically Changbin Du
2020-07-17 14:36 ` [PATCH v6 02/17] perf ftrace: add option '-F/--funcs' to list available functions Changbin Du
2020-07-17 14:52 ` Arnaldo Carvalho de Melo
2020-07-17 14:36 ` [PATCH v6 03/17] perf ftrace: factor out function write_tracing_file_int() Changbin Du
2020-07-17 14:36 ` [PATCH v6 04/17] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size Changbin Du
2020-07-17 14:36 ` [PATCH v6 05/17] perf ftrace: show trace column header Changbin Du
2020-07-17 14:36 ` [PATCH v6 06/17] perf ftrace: add option '--inherit' to trace children processes Changbin Du
2020-07-17 14:36 ` [PATCH v6 07/17] perf: util: add general function to parse sublevel options Changbin Du
2020-07-17 14:36 ` [PATCH v6 08/17] perf ftrace: add support for tracing option 'func_stack_trace' Changbin Du
2020-07-17 14:36 ` [PATCH v6 09/17] perf ftrace: add support for trace option sleep-time Changbin Du
2020-07-17 14:36 ` [PATCH v6 10/17] perf ftrace: add support for trace option funcgraph-irqs Changbin Du
2020-07-17 14:36 ` [PATCH v6 11/17] perf ftrace: add support for tracing option 'irq-info' Changbin Du
2020-07-17 14:36 ` [PATCH v6 12/17] perf ftrace: add option 'verbose' to show more info for graph tracer Changbin Du
2020-07-17 14:36 ` [PATCH v6 13/17] perf ftrace: add support for trace option tracing_thresh Changbin Du
2020-07-17 14:36 ` [PATCH v6 14/17] perf: ftrace: allow set graph depth by '--graph-opts' Changbin Du
2020-07-17 14:36 ` Changbin Du [this message]
2020-07-17 14:36 ` [PATCH v6 16/17] perf: ftrace: Add set_tracing_options() to set all trace options Changbin Du
2020-07-17 14:36 ` [PATCH v6 17/17] perf ftrace: add change log Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717143628.47721-16-changbin.du@gmail.com \
--to=changbin.du@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox