From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34BD4C433DF for ; Fri, 17 Jul 2020 14:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0305520734 for ; Fri, 17 Jul 2020 14:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594997699; bh=ekESCmOxSsO99Jgr9mXcv5Rm5ARC6YWFI2L+02tuKtU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=C27Yzbl8Bvva9oIrXqQGDywYqqX/YMtXbO3dR5ciA7NhEHx4MopRgt4vZhgOl7K7R qxhdA8t7HXjIK4LVs6Df8AIun/rUl9ZwJfsR3dHJd/s7ut67iM0oao5J3fs0aFCvAG h2UbB9nTfNAf75q2z/l7cc8noOGo5S9LUgB7yMVY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726673AbgGQOy5 (ORCPT ); Fri, 17 Jul 2020 10:54:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:59914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726233AbgGQOy5 (ORCPT ); Fri, 17 Jul 2020 10:54:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59BAE2070E; Fri, 17 Jul 2020 14:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594997696; bh=ekESCmOxSsO99Jgr9mXcv5Rm5ARC6YWFI2L+02tuKtU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GzsOV7ABb0hP1Foh8qEttWwWQ/tenkJ7GyhQaR69Y02hFYIqSrNt7sEEqkwhVEroF SM+RQUD7gxa41FoAgpsG71eQv9YJ9EHA/lprT3b0SomSeCl2M4TEA5fbwUA3LCTS1z Tr9PV63pPpVPtoQqlw6yGTEZHO1fuLqTSJY6F8IM= Date: Fri, 17 Jul 2020 16:54:48 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Daniel Gutson , Derek Kiernan , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mika Westerberg , Mauro Carvalho Chehab , "linux-kernel@vger.kernel.org" , Richard Hughes , Alex Bazhaniuk Subject: Re: [PATCH] [PATCH] Firmware security information in SYSFS Message-ID: <20200717145448.GA3008378@kroah.com> References: <20200716223627.253936-1-daniel.gutson@eclypsium.com> <20200717062841.GA3238569@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2020 at 04:40:40PM +0200, Arnd Bergmann wrote: > On Fri, Jul 17, 2020 at 8:28 AM Greg Kroah-Hartman > wrote: > > > > On Thu, Jul 16, 2020 at 07:36:27PM -0300, Daniel Gutson wrote: > > > +What: /sys/kernel/firmware-security/bioswe > > > > Ick, I stopped reading right here. > > > > No, this is not where this belongs. > > > > We already have /sys/firmware/, right? And firmware-specific > > subdirectories below that. > > > > We also have /sys/devices/system/ and I think that would be a much > > better place for this, as it is easier to work with a real 'struct > > device' than a "raw" kobject any day. Bonus is you get full support of > > userspace libraries when you do that, unlike when dealing with kobjects. > > > > Also, this really is a _SPECIFIC_ type of firmware that supports these > > features, right? Why not call that out too? This is not generic by any > > means. > > As I suggested in my previous review, I wouldn't worry too much about > the user interface at the start, but instead first work out how the hardware > support fits in with the existing drivers and once that looks fine decide > on how to export it to user space. > > I agree the /sys/kernel/firmware-security/bioswe sounds like the wrong > place, but I'm not sure if adding any other new directory in sysfs is > much better. I think the most promising would be to have it on the > sysfs directory for the device it refers to, but let's first see how the > information gets into the kernel. Yes, the directory for the specific device would probably be best, but let's see where that really is :) thanks, greg k-h