RE: [PATCH 04/20] dlb2: add device ioctl layer and first 4 ioctls

Eads, Gage
2020-07-17T18:20:22Z

> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Sunday, July 12, 2020 9:42 AM
> To: Eads, Gage <gage.eads@intel.com>; linux-kernel@vger.kernel.org;
> arnd@arndb.de; gregkh@linuxfoundation.org
> Cc: Karlsson, Magnus <magnus.karlsson@intel.com>; Topel, Bjorn
> <bjorn.topel@intel.com>
> Subject: Re: [PATCH 04/20] dlb2: add device ioctl layer and first 4 ioctls
>
> On 7/12/20 6:43 AM, Gage Eads wrote:
> > +/********************/
> > +/* dlb2 ioctl codes */
> > +/********************/
> > +
> > +#define DLB2_IOC_MAGIC 'h'
>
> Hi,
> This magic value should be documented in Documentation/userspace-
> api/ioctl/ioctl-number.rst.
>
> thanks.
> --
> ~Randy

Will fix in v2.

Thanks,
Gage