From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C66FC433E0 for ; Sat, 18 Jul 2020 15:12:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CA4C2076A for ; Sat, 18 Jul 2020 15:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085161; bh=ZXDpzjGQTX/1ao0lxIcUm62D8ruThRSvhtkdngCE+30=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=EjznfqJfSA+8Dcg8XlCo98K0oxIk0CVH4n2yErkI4JlRE56gX/iHLFT5fHI3fgN2w MU8T2x+Sv9LmL9ZmfVmS3d1flyAaWxivedqnRlGkOIOyXCppShLV/hNZEml1Z3EkI2 RAvWOv+uS6+oIltiYdddTYcA5qwUM5dWnewHQTpU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726775AbgGRPMk (ORCPT ); Sat, 18 Jul 2020 11:12:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:37696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgGRPMj (ORCPT ); Sat, 18 Jul 2020 11:12:39 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F329F2067D; Sat, 18 Jul 2020 15:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085159; bh=ZXDpzjGQTX/1ao0lxIcUm62D8ruThRSvhtkdngCE+30=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L8FK0JVyFXFNzbiwCTyQmwcSVHeP1d67dVsMd5DpEY1WJBdYUQqkk+Ke4WHKDGIEX AHlSb4NBRTI2uRzvvz1eUW1kdCIGOv4s+8u5S2W1mh8JMueD3Ebfh+PBmyD9l5pSS0 S9FtlyhnoOFzvQbbGo48ewFfKmAMrMZOjo24Hci0= Date: Sat, 18 Jul 2020 16:12:34 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich Subject: Re: [PATCH 26/30] iio: dac: ad5791: Complete 'struct ad5791_chip_info' documentation Message-ID: <20200718161234.70f19620@archlinux> In-Reply-To: <20200716135928.1456727-27-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-27-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:24 +0100 Lee Jones wrote: > ... and remove seemingly pointless comment. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'ctrl' not described in 'ad5791_state' > drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5791_state' > drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'pwr_down' not described in 'ad5791_state' > drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'data' not described in 'ad5791_state' > drivers/iio/dac/ad5791.c:103: warning: cannot understand function prototype: 'enum ad5791_supported_device_ids ' > > Cc: Michael Hennerich > Signed-off-by: Lee Jones Applied. Thanks, Jonathan > --- > drivers/iio/dac/ad5791.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/dac/ad5791.c b/drivers/iio/dac/ad5791.c > index 1d11f39ed0474..d8485004b1010 100644 > --- a/drivers/iio/dac/ad5791.c > +++ b/drivers/iio/dac/ad5791.c > @@ -76,9 +76,11 @@ struct ad5791_chip_info { > * @chip_info: chip model specific constants > * @vref_mv: actual reference voltage used > * @vref_neg_mv: voltage of the negative supply > - * @pwr_down_mode current power down mode > + * @ctrl: control regster cache > + * @pwr_down_mode: current power down mode > + * @pwr_down: true if device is powered down > + * @data: spi transfer buffers > */ > - > struct ad5791_state { > struct spi_device *spi; > struct regulator *reg_vdd; > @@ -96,10 +98,6 @@ struct ad5791_state { > } data[3] ____cacheline_aligned; > }; > > -/** > - * ad5791_supported_device_ids: > - */ > - > enum ad5791_supported_device_ids { > ID_AD5760, > ID_AD5780,