From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38FFC433E0 for ; Sat, 18 Jul 2020 16:36:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A99EA2080D for ; Sat, 18 Jul 2020 16:36:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727037AbgGRQgD (ORCPT ); Sat, 18 Jul 2020 12:36:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726604AbgGRQgD (ORCPT ); Sat, 18 Jul 2020 12:36:03 -0400 X-Greylist: delayed 594 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 18 Jul 2020 09:36:03 PDT Received: from saturn.retrosnub.co.uk (saturn.retrosnub.co.uk [IPv6:2a00:1098:86::1:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4477CC0619D2 for ; Sat, 18 Jul 2020 09:36:03 -0700 (PDT) Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id C67F99E0030; Sat, 18 Jul 2020 17:26:05 +0100 (BST) Date: Sat, 18 Jul 2020 17:26:04 +0100 From: Jonathan Cameron To: "Ardelean, Alexandru" Cc: "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" , "Tachici, Alexandru" Subject: Re: [PATCH v4 2/2] iio: adc: ad7192: move ad7192_of_match table closer to the end of the file Message-ID: <20200718172604.4257a4f8@archlinux> In-Reply-To: <191e9880ea3dd0e127b102f006c208f31d57c421.camel@analog.com> References: <20200415055804.17971-1-alexandru.ardelean@analog.com> <20200415055804.17971-2-alexandru.ardelean@analog.com> <191e9880ea3dd0e127b102f006c208f31d57c421.camel@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jul 2020 16:11:39 +0000 "Ardelean, Alexandru" wrote: > On Wed, 2020-04-15 at 08:58 +0300, Alexandru Ardelean wrote: > > The change is more cosmetic. There is no need to reference this table in > > the probe function since 'of_device_get_match_data' is used, which > > obtains > > this information from the driver object. > > This looks like it could be applied now. > The iio/testing branch seems to have patch [1/2]. Thanks. Applied. Jonathan > > Thanks > Alex > > > > > Signed-off-by: Alexandru Ardelean > > --- > > drivers/iio/adc/ad7192.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c > > index 1431f555daa6..fd89a5115c55 100644 > > --- a/drivers/iio/adc/ad7192.c > > +++ b/drivers/iio/adc/ad7192.c > > @@ -908,15 +908,6 @@ static int ad7192_channels_config(struct iio_dev > > *indio_dev) > > return 0; > > } > > > > -static const struct of_device_id ad7192_of_match[] = { > > - { .compatible = "adi,ad7190", .data = > > &ad7192_chip_info_tbl[ID_AD7190] }, > > - { .compatible = "adi,ad7192", .data = > > &ad7192_chip_info_tbl[ID_AD7192] }, > > - { .compatible = "adi,ad7193", .data = > > &ad7192_chip_info_tbl[ID_AD7193] }, > > - { .compatible = "adi,ad7195", .data = > > &ad7192_chip_info_tbl[ID_AD7195] }, > > - {} > > -}; > > -MODULE_DEVICE_TABLE(of, ad7192_of_match); > > - > > static int ad7192_probe(struct spi_device *spi) > > { > > struct ad7192_state *st; > > @@ -1050,6 +1041,15 @@ static int ad7192_remove(struct spi_device *spi) > > return 0; > > } > > > > +static const struct of_device_id ad7192_of_match[] = { > > + { .compatible = "adi,ad7190", .data = > > &ad7192_chip_info_tbl[ID_AD7190] }, > > + { .compatible = "adi,ad7192", .data = > > &ad7192_chip_info_tbl[ID_AD7192] }, > > + { .compatible = "adi,ad7193", .data = > > &ad7192_chip_info_tbl[ID_AD7193] }, > > + { .compatible = "adi,ad7195", .data = > > &ad7192_chip_info_tbl[ID_AD7195] }, > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of, ad7192_of_match); > > + > > static struct spi_driver ad7192_driver = { > > .driver = { > > .name = "ad7192",