[PATCH] staging: rtl8192e: Fixed the space and indentation coding styles

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] staging: rtl8192e: Fixed the space and indentation coding styles
@ 2020-07-17 15:04 Darshan D V
  2020-07-19  9:22 ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Darshan D V @ 2020-07-17 15:04 UTC (permalink / raw)
  To: gregkh, yuehaibing, ardb, contact; +Cc: darshandv10, devel, linux-kernel

rtllib_crypt_ccmp.c: Fixed the error - space required before the
open parenthesis '(' on line #281.

rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for
conditional statements on line #338

Signed-off-by: Darshan D V <darshandv10@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index 0cbf4a1a326b..b60e2a109ce4 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 		int aad_len, ret;
 
 		req = aead_request_alloc(key->tfm, GFP_ATOMIC);
-		if(!req)
+		if (!req)
 			return -ENOMEM;
 
 		aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
@@ -337,7 +337,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
 		}
 		if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) ||
 			crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN))
-				return -1;
+			return -1;
 	} else if (len == 0) {
 		data->key_set = 0;
 	} else {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] staging: rtl8192e: Fixed the space and indentation coding styles
  2020-07-17 15:04 [PATCH] staging: rtl8192e: Fixed the space and indentation coding styles Darshan D V
@ 2020-07-19  9:22 ` Greg KH
  2020-07-19 10:55   ` [PATCH 1/2] staging: rtl8192e: Fixed a coding style error Darshan D V
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2020-07-19  9:22 UTC (permalink / raw)
  To: Darshan D V; +Cc: yuehaibing, ardb, contact, devel, linux-kernel

On Fri, Jul 17, 2020 at 08:34:51PM +0530, Darshan D V wrote:
> rtllib_crypt_ccmp.c: Fixed the error - space required before the
> open parenthesis '(' on line #281.
> 
> rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for
> conditional statements on line #338
> 
> Signed-off-by: Darshan D V <darshandv10@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> index 0cbf4a1a326b..b60e2a109ce4 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> @@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
>  		int aad_len, ret;
>  
>  		req = aead_request_alloc(key->tfm, GFP_ATOMIC);
> -		if(!req)
> +		if (!req)
>  			return -ENOMEM;
>  
>  		aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
> @@ -337,7 +337,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
>  		}
>  		if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) ||
>  			crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN))
> -				return -1;
> +			return -1;
>  	} else if (len == 0) {
>  		data->key_set = 0;
>  	} else {
> -- 
> 2.17.1


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] staging: rtl8192e: Fixed a coding style error
  2020-07-19  9:22 ` Greg KH
@ 2020-07-19 10:55   ` Darshan D V
  2020-07-19 10:55     ` [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning Darshan D V
  2020-07-19 11:05     ` [PATCH 1/2] staging: rtl8192e: Fixed a coding style error Greg KH
  0 siblings, 2 replies; 6+ messages in thread
From: Darshan D V @ 2020-07-19 10:55 UTC (permalink / raw)
  To: gregkh, yuehaibing, ardb, contact; +Cc: devel, linux-kernel, darshandv10

    rtllib_crypt_ccmp.c: Fixed the error - space required before the
    open parenthesis '(' on line #281.

Signed-off-by: Darshan D V <darshandv10@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index 0cbf4a1a326b..b2af802b9451 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 		int aad_len, ret;
 
 		req = aead_request_alloc(key->tfm, GFP_ATOMIC);
-		if(!req)
+		if (!req)
 			return -ENOMEM;
 
 		aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning
  2020-07-19 10:55   ` [PATCH 1/2] staging: rtl8192e: Fixed a coding style error Darshan D V
@ 2020-07-19 10:55     ` Darshan D V
  2020-07-19 11:05       ` Greg KH
  2020-07-19 11:05     ` [PATCH 1/2] staging: rtl8192e: Fixed a coding style error Greg KH
  1 sibling, 1 reply; 6+ messages in thread
From: Darshan D V @ 2020-07-19 10:55 UTC (permalink / raw)
  To: gregkh, yuehaibing, ardb, contact; +Cc: devel, linux-kernel, darshandv10

    rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for
    conditional statements on line #338

Signed-off-by: Darshan D V <darshandv10@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index b2af802b9451..b60e2a109ce4 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -337,7 +337,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
 		}
 		if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) ||
 			crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN))
-				return -1;
+			return -1;
 	} else if (len == 0) {
 		data->key_set = 0;
 	} else {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning
  2020-07-19 10:55     ` [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning Darshan D V
@ 2020-07-19 11:05       ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-07-19 11:05 UTC (permalink / raw)
  To: Darshan D V; +Cc: yuehaibing, ardb, contact, devel, linux-kernel

On Sun, Jul 19, 2020 at 04:25:57PM +0530, Darshan D V wrote:
>     rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for
>     conditional statements on line #338

You can't send two patches that do two different things, yet have the
same exact subject: line :(


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] staging: rtl8192e: Fixed a coding style error
  2020-07-19 10:55   ` [PATCH 1/2] staging: rtl8192e: Fixed a coding style error Darshan D V
  2020-07-19 10:55     ` [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning Darshan D V
@ 2020-07-19 11:05     ` Greg KH
  1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-07-19 11:05 UTC (permalink / raw)
  To: Darshan D V; +Cc: yuehaibing, ardb, contact, devel, linux-kernel

On Sun, Jul 19, 2020 at 04:25:56PM +0530, Darshan D V wrote:
>     rtllib_crypt_ccmp.c: Fixed the error - space required before the
>     open parenthesis '(' on line #281.

What does this mean for a changelog text?

And why is it indented?

Did you read the section in the submitting patches document about how to
write a changelog text?  Perhaps you might want to re-read that :)

> Signed-off-by: Darshan D V <darshandv10@gmail.com>

Is this how you sign legal documents?  If so, great, but I have to ask.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-07-19 11:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-17 15:04 [PATCH] staging: rtl8192e: Fixed the space and indentation coding styles Darshan D V
2020-07-19  9:22 ` Greg KH
2020-07-19 10:55   ` [PATCH 1/2] staging: rtl8192e: Fixed a coding style error Darshan D V
2020-07-19 10:55     ` [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning Darshan D V
2020-07-19 11:05       ` Greg KH
2020-07-19 11:05     ` [PATCH 1/2] staging: rtl8192e: Fixed a coding style error Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox