From: Al Viro <viro@zeniv.linux.org.uk>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: ericvh@gmail.com, hch@lst.de, dhowells@redhat.com,
lucho@ionkov.net, asmadeus@codewreck.org,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Kaly.Xin@arm.com,
justin.he@arm.com, wei.chen@arm.com
Subject: Re: [RFC PATCH 0/2] vfs:9p: fix open-unlink-fstat bug
Date: Mon, 20 Jul 2020 02:52:12 +0100 [thread overview]
Message-ID: <20200720015212.GN2786714@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200720014622.37364-1-jianyong.wu@arm.com>
On Mon, Jul 20, 2020 at 09:46:20AM +0800, Jianyong Wu wrote:
> how to reproduce:
> in 9p guest:
>
> struct stat *statbuf;
> int fd;
>
> fd = open("tmp", O_RDWR);
> unlink("tmp");
> fstat(fd, statbuf);
>
> fstat will fail as "tmp" in 9p server side has been removed. 9p server
> can't retrieve the file context as the guest has not passed it down.
> so we should pass the file info down in 9p guest in getattr op.
> it need add a new file member in "struct kstat" as "struct istat" does.
Er... what struct istat?
next prev parent reply other threads:[~2020-07-20 1:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 1:46 [RFC PATCH 0/2] vfs:9p: fix open-unlink-fstat bug Jianyong Wu
2020-07-20 1:46 ` [RFC PATCH 1/2] vfs: pass file down when getattr to avoid losing info Jianyong Wu
2020-07-20 14:53 ` Dominique Martinet
2020-07-21 10:03 ` Jianyong Wu
2020-07-20 1:46 ` [RFC PATCH 2/2] 9p: retrieve fid from file if it exists when getattr Jianyong Wu
2020-07-20 1:52 ` Al Viro [this message]
2020-07-20 1:58 ` [RFC PATCH 0/2] vfs:9p: fix open-unlink-fstat bug Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720015212.GN2786714@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Kaly.Xin@arm.com \
--cc=asmadeus@codewreck.org \
--cc=dhowells@redhat.com \
--cc=ericvh@gmail.com \
--cc=hch@lst.de \
--cc=jianyong.wu@arm.com \
--cc=justin.he@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=wei.chen@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox