From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: ricky_wu@realtek.com, Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
rui_feng@realsil.com.cn, Bjorn Helgaas <bhelgaas@google.com>,
kdlnx@doth.eu, Rui Miguel Silva <rmfrfs@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] misc: rtsx: Add support new chip rts5228 mmc: rtsx: Add support MMC_CAP2_NO_MMC
Date: Mon, 20 Jul 2020 15:54:32 +0100 [thread overview]
Message-ID: <20200720145432.GB621928@dell> (raw)
In-Reply-To: <20200720145202.GA621928@dell>
On Mon, 20 Jul 2020, Lee Jones wrote:
> On Mon, 20 Jul 2020, Linus Walleij wrote:
>
> > On Mon, Jul 6, 2020 at 9:03 AM <ricky_wu@realtek.com> wrote:
> >
> > > drivers/misc/cardreader/Makefile | 2 +-
> > > drivers/misc/cardreader/rts5228.c | 740 +++++++++++++++++++++++++++++
> > > drivers/misc/cardreader/rts5228.h | 168 +++++++
> > > drivers/misc/cardreader/rtsx_pcr.c | 89 ++--
> > > drivers/misc/cardreader/rtsx_pcr.h | 5 +
> >
> > This drivers/misc/cardreader business is a big confusion for my mind.
> >
> > Is it really that fantastic that it needs to be a unique special case?
> >
> > To me it looks like a drivers/mfd thing which should have separate
> > drivers/regulator/rts5228.c (LDOs)
> > drivers/clk/rts5228.c (clocks)
> > subdrivers.
> >
> > See for example drivers/mfd/sta2x11-mfd.c thay spawns a few
> > devices off a PCI card.
>
> Thanks for Cc'ing me Linus.
>
> Can you please bounce the diff to me too?
Never mind, I found it.
So you may use MFD to register the (regulator, clk, card reader) child
devices, but pretty much none of that *functional* code belongs in
drivers/mfd.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-20 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 7:02 [PATCH] misc: rtsx: Add support new chip rts5228 mmc: rtsx: Add support MMC_CAP2_NO_MMC ricky_wu
2020-07-18 9:43 ` Ulf Hansson
2020-07-20 14:15 ` Linus Walleij
2020-07-20 14:52 ` Lee Jones
2020-07-20 14:54 ` Lee Jones [this message]
2020-07-20 22:06 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720145432.GB621928@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kdlnx@doth.eu \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=rmfrfs@gmail.com \
--cc=rui_feng@realsil.com.cn \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox