From: Alex Williamson <alex.williamson@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Cornelia Huck <cohuck@redhat.com>,
prime.zeng@hisilicon.com
Subject: Re: [GIT PULL] VFIO fix for v5.8-rc7
Date: Mon, 20 Jul 2020 15:01:38 -0600 [thread overview]
Message-ID: <20200720150138.5c13e8b9@x1.home> (raw)
In-Reply-To: <CAHk-=wijGPPiUH8-kzu2ZyP9_SgBxbGib7afOMAwpusfx-2K+g@mail.gmail.com>
On Mon, 20 Jul 2020 13:33:29 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, Jul 20, 2020 at 7:34 AM Alex Williamson
> <alex.williamson@redhat.com> wrote:
> >
> > VFIO fixes for v5.8-rc7
> >
> > - Fix race with eventfd ctx cleared outside of mutex (Zeng Tao)
>
> Why does this take and then re-take the lock immediately? That just
> looks insane.
>
> I realize that this isn't likely to be a performance-critical path,
> but this is a basic source cleanliness issue. Doing silly things is
> silly, and shouldn't be done, even if they don't matter.
Yup, it's silly. Cornelia identified the same during review and I let
it slide after some counter arguments by the submitter. I see this got
merged, so I'll post a cleanup for v5.9. Thanks for the input,
Alex
next prev parent reply other threads:[~2020-07-20 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 14:34 [GIT PULL] VFIO fix for v5.8-rc7 Alex Williamson
2020-07-20 20:33 ` Linus Torvalds
2020-07-20 21:01 ` Alex Williamson [this message]
2020-07-20 20:50 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720150138.5c13e8b9@x1.home \
--to=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prime.zeng@hisilicon.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox