From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9B4C433E7 for ; Mon, 20 Jul 2020 16:08:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FA972064B for ; Mon, 20 Jul 2020 16:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261322; bh=7A716F5omD/M+9549xHMdWlShMiF/sNXmsejAVJPGK0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=izK8i/fG9qsoGZo4sJGDI9PVVkK6IsTjUOo4DJe3foks55q6p2oAZ2TE+DGa7VPJb Me31IHGcCj7pI7404N/RhnUHhaNwUt+yeVeBP7IjhYal9ssP1O1CSAdfHVAJxSrOS0 mgUa4tVvXIv5ziVwjvOr2f75APzdg4YCRszqydwE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387422AbgGTQIk (ORCPT ); Mon, 20 Jul 2020 12:08:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:46144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733053AbgGTQIi (ORCPT ); Mon, 20 Jul 2020 12:08:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25775206E9; Mon, 20 Jul 2020 16:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261317; bh=7A716F5omD/M+9549xHMdWlShMiF/sNXmsejAVJPGK0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j0MtT9k3mCKW65m8916PwZXKAR2kfBA5tNLlEq37Nxk50V1RevuGeDLF+q/GwZgp4 zrH0pK9oFBbMlJPjq73czGC1sR+WpKm3Qg19H1wjGWwaicrCsduJjkCY/bht6h77eH x7Xz2Aa/wxsUaJ+hGVRyEE+IrGzwhJeaiNA7UtW8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sascha Hauer , Russell King , "David S. Miller" , Sasha Levin Subject: [PATCH 5.7 071/244] net: ethernet: mvneta: Do not error out in non serdes modes Date: Mon, 20 Jul 2020 17:35:42 +0200 Message-Id: <20200720152829.217948901@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152825.863040590@linuxfoundation.org> References: <20200720152825.863040590@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sascha Hauer [ Upstream commit d3d239dcb8aae6d7b10642d292b404e57604f7ea ] In mvneta_config_interface() the RGMII modes are catched by the default case which is an error return. The RGMII modes are valid modes for the driver, so instead of returning an error add a break statement to return successfully. This avoids this warning for non comphy SoCs which use RGMII, like SolidRun Clearfog: WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c Fixes: b4748553f53f ("net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy") Signed-off-by: Sascha Hauer Reviewed-by: Russell King Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index cf26cf4e47aa8..7faeb4bfc282e 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -3565,7 +3565,7 @@ static int mvneta_config_interface(struct mvneta_port *pp, MVNETA_HSGMII_SERDES_PROTO); break; default: - return -EINVAL; + break; } } -- 2.25.1