From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB85C433E0 for ; Tue, 21 Jul 2020 10:32:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D30F2077D for ; Tue, 21 Jul 2020 10:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595327555; bh=cxxwkqmECry30G57dJfjbrdgXLTLNOm11+JAi8PcStY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WO7omIw70DHzoeVv6iLa8UUf4B5R0v6NNKfR0zan1FsAX/vUz/T70kVtrqrmHEUjF VnUw6tqVouEd1ULGJnNfl/ZTiBsEn+SYe0LC9Du2y1kVOOQTboSQvKKI1OM65aemQe AIf24+ri18PJ/5GKnGSmHtuKV4GeavqSNHSfqoxw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729342AbgGUKce (ORCPT ); Tue, 21 Jul 2020 06:32:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:56394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbgGUKcd (ORCPT ); Tue, 21 Jul 2020 06:32:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A430F20714; Tue, 21 Jul 2020 10:32:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595327553; bh=cxxwkqmECry30G57dJfjbrdgXLTLNOm11+JAi8PcStY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AKZjg+PFoyxwyMHNsCZgBRR1twDK3EjuiNqHsHgeLDzNV7CVW7pntD9R/9AKKg6q0 kYJqFCUE6yac809FGnMqyOB6JNYSZfOe7+vSum1nRyPdQWFfMxkTichzH69C7/Dpfw B9+UX2XRQR6bh7oi42qqYFkAfhFFVJNzChr/oCsI= Date: Tue, 21 Jul 2020 12:32:41 +0200 From: Greg KH To: ivan Cc: sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com, Qiwu Huang Subject: Re: [PATCH v5 3/4] power: supply: core: add wireless signal strength property Message-ID: <20200721103241.GA1675802@kroah.com> References: <20200721082000.GD1655283@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 06:21:20PM +0800, ivan wrote: > On Tue, Jul 21, 2020 at 4:19 PM Greg KH wrote: > > > > On Tue, Jul 21, 2020 at 01:59:36PM +0800, Qiwu Huang wrote: > > > From: Qiwu Huang > > > > > > reports wireless signal strength. > > > The value show degree of coupling between tx and rx. > > > > > > Signed-off-by: Qiwu Huang > > > --- > > > Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++ > > > drivers/power/supply/power_supply_sysfs.c | 1 + > > > include/linux/power_supply.h | 1 + > > > 3 files changed, 12 insertions(+) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > > > index 03ab449fae8a..75ec7de2fe78 100644 > > > --- a/Documentation/ABI/testing/sysfs-class-power > > > +++ b/Documentation/ABI/testing/sysfs-class-power > > > @@ -757,3 +757,13 @@ Description: > > > 13: ADAPTER_VOICE_BOX, > > > 14: ADAPTER_PRIVATE_PD_50W. > > > > > > +What: /sys/class/power_supply//signal_strength > > > +Date: Jul 2020 > > > +Contact: Fei Jiang > > > +Description: > > > + In PING phase, RX transmits a signal strength packet as the first > > > > What does "PING phase" mean? > > The Qi Wireless Power Transfer System is published by the Wireless > Power Consortium. > The ping phase is the necessary stage for matching transmitter and > receiver. In this phase, > the Power Transmitter executes a Digital Ping, and listens for a > response. If the > Power Transmitter discovers a Power Receiver, the Power Transmitter > may extend the Digital Ping, > i.e. maintain the Power Signal at the level of the Digital Ping. This > causes the system to proceed to the > identification & configuration phase. If the Power Transmitter does > not extend the Digital Ping, the > system shall revert to the selection phase. Thanks for the description, so perhaps turning this response into the text in the description would be good? thanks, greg k-h