From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D91CC433E3 for ; Tue, 21 Jul 2020 23:16:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F412C20771 for ; Tue, 21 Jul 2020 23:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595373418; bh=hVoIbwbVywgC7jhgVpXyOg5Fgl2JP3Aj80jHW2Xpo1E=; h=Date:From:To:Cc:Subject:List-ID:From; b=V8V9oELJf5uH4Rz46pzb/p51NGApafipSnGNFRvsTGRYOkqEuJ/A9xeVDRhM80S3g HNXaguFv//WsOfP0htDV1u7pfF6+7EFmp4Thxc2bW0z5qgCjXV133mdYBXf88AS05w cTPebDyf0oHi+1wtD08F8z8M38aRT0UuK92ieOKs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731407AbgGUXQ5 (ORCPT ); Tue, 21 Jul 2020 19:16:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:36936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbgGUXQ4 (ORCPT ); Tue, 21 Jul 2020 19:16:56 -0400 Received: from embeddedor (unknown [201.162.241.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 233EF20709; Tue, 21 Jul 2020 23:16:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595373416; bh=hVoIbwbVywgC7jhgVpXyOg5Fgl2JP3Aj80jHW2Xpo1E=; h=Date:From:To:Cc:Subject:From; b=Fp5SizZkI1S27qPov0v2tJKWGpC3fv96PEL+YzE1RTMcEPyS1KVX0IxgIauuOWg6u aBY9uro+SVXllKXsL9kwXMTQg2YKPia5OMCB7mPYqQPODVOqq7Iljo9o4VB/CHSjcf dAknsI1IwzhwPhlpRO5PcNHrZ5I/fNAianXFsRwo= Date: Tue, 21 Jul 2020 18:22:32 -0500 From: "Gustavo A. R. Silva" To: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery Cc: linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH v2][next] i2c: aspeed: Use fallthrough pseudo-keyword Message-ID: <20200721232231.GA1888@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Reviewed-by: Brendan Higgins Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Update URL. Use proper URL to Linux v5.7 documentation. - Add Brendan's Reviewed-by tag. drivers/i2c/busses/i2c-aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index f51702d86a90..31268074c422 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c @@ -504,7 +504,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) goto error_and_stop; } irq_handled |= ASPEED_I2CD_INTR_TX_ACK; - /* fall through */ + fallthrough; case ASPEED_I2C_MASTER_TX_FIRST: if (bus->buf_index < msg->len) { bus->master_state = ASPEED_I2C_MASTER_TX; @@ -520,7 +520,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) /* RX may not have completed yet (only address cycle) */ if (!(irq_status & ASPEED_I2CD_INTR_RX_DONE)) goto out_no_complete; - /* fall through */ + fallthrough; case ASPEED_I2C_MASTER_RX: if (unlikely(!(irq_status & ASPEED_I2CD_INTR_RX_DONE))) { dev_err(bus->dev, "master failed to RX\n"); -- 2.27.0