Re: [PATCH 16/19] perf metric: Make compute_single function more precise

Arnaldo Carvalho de Melo
2020-07-29T11:08:50Z

Em Wed, Jul 29, 2020 at 01:47:01AM +0530, kajoljain escreveu:
>
>
> On 7/28/20 10:56 PM, Ian Rogers wrote:
> > On Tue, Jul 28, 2020 at 5:36 AM Arnaldo Carvalho de Melo
> > <acme@kernel.org> wrote:
> >>
> >> Em Sun, Jul 19, 2020 at 08:13:17PM +0200, Jiri Olsa escreveu:
> >>> So far compute_single function relies on the fact, that
> >>> there's only single metric defined within evlist in all
> >>> tests. In following patch we will add test for metric
> >>> group, so we need to be able to compute metric by given
> >>> name.
> >>>
> >>> Adding the name argument to compute_single and iterating
> >>> evlist and evsel's expression to find the given metric.
> >>
> >> Applied, thanks.
> >>
> >> Ian, Kajol, I didn't notice your Acked-by or Reviewed-by, like for the
> >> other patches, can you check?
> >
> >
> > Acked-by: Ian Rogers <irogers@google.com>
>
> Reviewed-By: Kajol Jain<kjain@linux.ibm.com>

Thanks, updated the patch with both tags,

- Arnaldo