* [PATCH] bpf: BPF_SYSCALL depends INET
@ 2020-07-23 14:19 trix
2020-07-23 15:27 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2020-07-23 14:19 UTC (permalink / raw)
To: ast, daniel, kafai, songliubraving, yhs, andriin, john.fastabend,
kpsingh, masahiroy, mhiramat, rostedt, akpm, will, krzk,
patrick.bellasi, dhowells, ebiederm, hannes
Cc: linux-kernel, netdev, bpf, Tom Rix
From: Tom Rix <trix@redhat.com>
A link error
kernel/bpf/net_namespace.o: In function `bpf_netns_link_release':
net_namespace.c: undefined reference to `bpf_sk_lookup_enabled'
bpf_sk_lookup_enabled is defined with INET
net_namespace is controlled by BPF_SYSCALL
So add a depends on INET to BPF_SYSCALL
Signed-off-by: Tom Rix <trix@redhat.com>
---
init/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/init/Kconfig b/init/Kconfig
index 7b8ef43e7fb4..817f70e6023c 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1663,6 +1663,7 @@ config BPF_SYSCALL
bool "Enable bpf() system call"
select BPF
select IRQ_WORK
+ depends on INET
default n
help
Enable the bpf() system call that allows to manipulate eBPF
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: BPF_SYSCALL depends INET
2020-07-23 14:19 [PATCH] bpf: BPF_SYSCALL depends INET trix
@ 2020-07-23 15:27 ` Alexei Starovoitov
2020-07-23 16:20 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Alexei Starovoitov @ 2020-07-23 15:27 UTC (permalink / raw)
To: trix
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, John Fastabend, KP Singh,
Masahiro Yamada, Masami Hiramatsu, Steven Rostedt, Andrew Morton,
Will Deacon, krzk, patrick.bellasi, David Howells,
Eric W. Biederman, Johannes Weiner, LKML, Network Development,
bpf
On Thu, Jul 23, 2020 at 7:19 AM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A link error
>
> kernel/bpf/net_namespace.o: In function `bpf_netns_link_release':
> net_namespace.c: undefined reference to `bpf_sk_lookup_enabled'
>
> bpf_sk_lookup_enabled is defined with INET
> net_namespace is controlled by BPF_SYSCALL
pls rebase. it was fixed already.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: BPF_SYSCALL depends INET
2020-07-23 15:27 ` Alexei Starovoitov
@ 2020-07-23 16:20 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2020-07-23 16:20 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, John Fastabend, KP Singh,
Masahiro Yamada, Masami Hiramatsu, Steven Rostedt, Andrew Morton,
Will Deacon, krzk, patrick.bellasi, David Howells,
Eric W. Biederman, Johannes Weiner, LKML, Network Development,
bpf
On 7/23/20 8:27 AM, Alexei Starovoitov wrote:
> On Thu, Jul 23, 2020 at 7:19 AM <trix@redhat.com> wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> A link error
>>
>> kernel/bpf/net_namespace.o: In function `bpf_netns_link_release':
>> net_namespace.c: undefined reference to `bpf_sk_lookup_enabled'
>>
>> bpf_sk_lookup_enabled is defined with INET
>> net_namespace is controlled by BPF_SYSCALL
> pls rebase. it was fixed already.
>
I guess it hasn't shown up in linux-next yet.
As i rebase every day, i'll get it evently.
Sorry for noise.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-23 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-23 14:19 [PATCH] bpf: BPF_SYSCALL depends INET trix
2020-07-23 15:27 ` Alexei Starovoitov
2020-07-23 16:20 ` Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox