Re: [PATCH v3 1/7] x86/boot/compressed: Move .got.plt entries out of the .got section

Arvind Sankar
2020-06-29T19:28:46Z

On Mon, Jun 29, 2020 at 08:48:05AM -0700, Kees Cook wrote:
> On Mon, Jun 29, 2020 at 10:09:22AM -0400, Arvind Sankar wrote:
>
> This is also being done on arm64, and the section was specified slightly
> differently (with INFO) which maybe should be done here too?

I was actually just about to email you to ask what that INFO is for :)
What does it do?

>
> .got.plt (INFO) : { *(.got.plt) }
> ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0x18, ".got.plt not empty")
>
> Otherwise, yes, looks good.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> > +
> > .data : {
> > _data = . ;
> > *(.data)
> > @@ -77,3 +80,9 @@ SECTIONS
> >
> > DISCARDS
> > }
> > +
> > +#ifdef CONFIG_X86_64
> > +ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0x18, "Unexpected GOT/PLT entries detected!")
> > +#else
> > +ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0xc, "Unexpected GOT/PLT entries detected!")
> > +#endif
> > --
> > 2.26.2
> >
>
> --
> Kees Cook