From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B30BC433E4 for ; Fri, 24 Jul 2020 18:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D678206F0 for ; Fri, 24 Jul 2020 18:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595616141; bh=VHNLbtVFSPjw830AY8q0WdAxdEMuFmcFp4kafvzppUE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=j5DZKCo29z06krxxt2m93cJAKBz5sj2vWnTxGUobjDOrcwhAgeRAqt/8fq9HMO7kB X8JW2wlEjJFVQHb6R8PWh7a3gTTSmAQjplqAVLlk2Kwx9fJsQubNYAXn0+OPVG3KUp PRT4u9LSKkbkMOqEFQeSfMqEZVp7Yz1oBQjyJWng= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726625AbgGXSmU (ORCPT ); Fri, 24 Jul 2020 14:42:20 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38253 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbgGXSmT (ORCPT ); Fri, 24 Jul 2020 14:42:19 -0400 Received: by mail-wr1-f65.google.com with SMTP id a14so9183284wra.5; Fri, 24 Jul 2020 11:42:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=J0wBk/6vaO0g7QfilA4yE/XNc/ENevl3w3KNoqKUGUg=; b=JX67EWFSrCgYUIaKKHEps2NspcqsAebnQvui8r2KffYses0crAF3xw/lEL/YwesbqS j2HE1Lrn5oZJC5z+z9iu6WayFwdz9DvXd0ZBqcNpWcNWPdiKCZC3Sv+WLtSQJ3S+hqR2 kUQxlpjHDMxXleRTAQNkmGEc7iuMegcKL2S6Ney5jB1xWdogeIjaYIuAhWTTyobymVNA Ss8gg6bL/yBqaND0hPvpmMkxkaQOuMaES7y9Wy41rjPPjzaBiKJn0H7GOoWGmH8VFLz2 HCM3RhwVKWwCCK7RSVOtZ8ldzfEjJ3yrqFMnk9ZKYQS851fXEcdooe1Pbp53LRQoa4Ur 28SA== X-Gm-Message-State: AOAM530dwiCJzorXTxvNaSyBI37ixUUjtGY3/Lii/x9AfMLWJqo1+z75 xODoIcnM2/Mid9USeZUfMRDxP6OnEfU= X-Google-Smtp-Source: ABdhPJzZJ+86rVVgc4VYErzo8iaWzUH13pTk1ZyZ0TGQDiMpbauNPPK8NiSa4t0knu/LgxjZ7ip5Ag== X-Received: by 2002:a5d:56c6:: with SMTP id m6mr10508907wrw.363.1595616137156; Fri, 24 Jul 2020 11:42:17 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id x11sm2174602wrl.28.2020.07.24.11.42.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Jul 2020 11:42:16 -0700 (PDT) Date: Fri, 24 Jul 2020 20:42:13 +0200 From: Krzysztof Kozlowski To: Florian Fainelli Cc: Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Russell King , Catalin Marinas , Will Deacon , Markus Mayer , Roger Quadros , Tony Lindgren , Vladimir Zapolskiy , Kukjin Kim , Lukasz Luba , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Olof Johansson , Arnd Bergmann Subject: Re: [RFT 12/16] memory: brcmstb_dpfe: Add separate entry for compile test Message-ID: <20200724184213.GA24993@kozik-lap> References: <20200724182328.3348-1-krzk@kernel.org> <20200724182328.3348-13-krzk@kernel.org> <7797a55e-bbf0-ef0f-daec-d56326167586@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7797a55e-bbf0-ef0f-daec-d56326167586@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2020 at 11:40:09AM -0700, Florian Fainelli wrote: > On 7/24/20 11:23 AM, Krzysztof Kozlowski wrote: > > Add separate entry for Broadcom STB DPFE driver, selected by platforms > > by default. This allows further customization and compile testing. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > > > I have other changes around drivers/memory/Kconfig pending. Sending them > > together would avoid conflicts. > > > > --- > > arch/arm/mach-bcm/Kconfig | 1 + > > arch/arm64/Kconfig.platforms | 1 + > > drivers/memory/Kconfig | 11 +++++++++++ > > drivers/memory/Makefile | 2 +- > > 4 files changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > > index 1df0ee01ee02..b0c45238e69b 100644 > > --- a/arch/arm/mach-bcm/Kconfig > > +++ b/arch/arm/mach-bcm/Kconfig > > @@ -208,6 +208,7 @@ config ARCH_BRCMSTB > > select ARM_GIC > > select ARM_ERRATA_798181 if SMP > > select HAVE_ARM_ARCH_TIMER > > + select BRCMSTB_DPFE > > select BRCMSTB_L2_IRQ > > select BCM7120_L2_IRQ > > select ARCH_HAS_HOLES_MEMORYMODEL > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > index ddc3bf75257f..f7791ed0ed6d 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -68,6 +68,7 @@ config ARCH_BRCMSTB > > bool "Broadcom Set-Top-Box SoCs" > > select ARCH_HAS_RESET_CONTROLLER > > select BCM7038_L1_IRQ > > + select BRCMSTB_DPFE > > The select is probably not warranted, see below. > > > select BRCMSTB_L2_IRQ > > select GENERIC_IRQ_CHIP > > select PINCTRL > > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > > index cd4fc93b50df..fef6f0873fda 100644 > > --- a/drivers/memory/Kconfig > > +++ b/drivers/memory/Kconfig > > @@ -54,6 +54,17 @@ config ATMEL_EBI > > tree is used. This bus supports NANDs, external ethernet controller, > > SRAMs, ATA devices, etc. > > > > +config BRCMSTB_DPFE > > + bool "Broadcom STB DPFE driver" if COMPILE_TEST > > + depends on ARCH_BRCMSTB || COMPILE_TEST > > Can you make it default ARCH_BRCMSTB and remove the select above? > > With that: > > Acked-by: Florian Fainelli Sure, I'll fix it up. Thanks for feedback. Best regards, Krzysztof