Re: [PATCH v5 07/10] bus: mhi: core: Introduce debugfs entries for MHI

kernel test robot
2020-07-24T04:14:13Z

[-- Attachment #1: Type: text/plain, Size: 5053 bytes --]

Hi Bhaumik,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.8-rc6 next-20200723]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Bhaumik-Bhatt/Introduce-features-and-debugfs-sysfs-entries-for-MHI/20200724-063954
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d15be546031cf65a0fc34879beca02fd90fe7ac7
config: csky-allyesconfig (attached as .config)
compiler: csky-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=csky

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/bus/mhi/core/debugfs.c: In function 'mhi_debugfs_events_show':
>> drivers/bus/mhi/core/debugfs.c:73:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
73 | seq_printf(m, " local rp: 0x%llx db: 0x%llx\n", (u64)ring->rp,
| ^
>> drivers/bus/mhi/core/debugfs.c:73:45: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
73 | seq_printf(m, " local rp: 0x%llx db: 0x%llx\n", (u64)ring->rp,
| ~~~^
| |
| long long unsigned int
| %x
74 | mhi_event->db_cfg.db_val);
| ~~~~~~~~~~~~~~~~~~~~~~~~
| |
| dma_addr_t {aka unsigned int}
drivers/bus/mhi/core/debugfs.c: In function 'mhi_debugfs_channels_show':
drivers/bus/mhi/core/debugfs.c:121:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
121 | (u64)ring->rp, (u64)ring->wp,
| ^
drivers/bus/mhi/core/debugfs.c:121:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
121 | (u64)ring->rp, (u64)ring->wp,
| ^
drivers/bus/mhi/core/debugfs.c:120:62: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
120 | seq_printf(m, " local rp: 0x%llx local wp: 0x%llx db: 0x%llx\n",
| ~~~^
| |
| long long unsigned int
| %x
121 | (u64)ring->rp, (u64)ring->wp,
122 | mhi_chan->db_cfg.db_val);
| ~~~~~~~~~~~~~~~~~~~~~~~
| |
| dma_addr_t {aka unsigned int}

vim +73 drivers/bus/mhi/core/debugfs.c

36
37 static int mhi_debugfs_events_show(struct seq_file *m, void *d)
38 {
39 struct mhi_controller *mhi_cntrl = m->private;
40 struct mhi_event *mhi_event;
41 struct mhi_event_ctxt *er_ctxt;
42 int i;
43
44 if (!mhi_is_active(mhi_cntrl)) {
45 seq_puts(m, "Device not ready\n");
46 return -ENODEV;
47 }
48
49 er_ctxt = mhi_cntrl->mhi_ctxt->er_ctxt;
50 mhi_event = mhi_cntrl->mhi_event;
51 for (i = 0; i < mhi_cntrl->total_ev_rings;
52 i++, er_ctxt++, mhi_event++) {
53 struct mhi_ring *ring = &mhi_event->ring;
54
55 if (mhi_event->offload_ev) {
56 seq_printf(m, "Index: %d is an offload event ring\n",
57 i);
58 continue;
59 }
60
61 seq_printf(m, "Index: %d intmod count: %lu time: %lu",
62 i, (er_ctxt->intmod & EV_CTX_INTMODC_MASK) >>
63 EV_CTX_INTMODC_SHIFT,
64 (er_ctxt->intmod & EV_CTX_INTMODT_MASK) >>
65 EV_CTX_INTMODT_SHIFT);
66
67 seq_printf(m, " base: 0x%0llx len: 0x%llx", er_ctxt->rbase,
68 er_ctxt->rlen);
69
70 seq_printf(m, " rp: 0x%llx wp: 0x%llx\n", er_ctxt->rp,
71 er_ctxt->wp);
72
> 73 seq_printf(m, " local rp: 0x%llx db: 0x%llx\n", (u64)ring->rp,
74 mhi_event->db_cfg.db_val);
75 }
76
77 return 0;
78 }
79

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64071 bytes --]