From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF02C433DF for ; Sun, 26 Jul 2020 09:42:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A76EC2065C for ; Sun, 26 Jul 2020 09:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595756558; bh=xU3mIY5/hOHJA9Dae120zT2CM7tU7BcJpSsWowzvqcU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=iBehksFSFHf3ad48Ap4XLexpbZ8dxiebS5XL2Y4iv++B/oYA58rBzQpM2Je5ls9Jc m87rDBxw+B/fXHEJ+qeRaW8v+eO1efYE5qCrcrkM0D2ryYYZEoyR8AJdtF7Sr/XZxq vXVc0E66bCrTmfcjTPWVGU83x4unaxGTm+HUag6o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbgGZJm3 (ORCPT ); Sun, 26 Jul 2020 05:42:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:52574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbgGZJm2 (ORCPT ); Sun, 26 Jul 2020 05:42:28 -0400 Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A5992065C; Sun, 26 Jul 2020 09:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595756548; bh=xU3mIY5/hOHJA9Dae120zT2CM7tU7BcJpSsWowzvqcU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Lm4qRcFfX69sVvN8HloMzZSOCi0Ezg2P6d3048kP4DtpGl11HJxusW9XiM2YhG1Z7 nOe9QBhlaD+gvKLOlmPPdYLbfkVxVTO2V0628CnUeQ2TTEgeT5bZkecaUA5I0L5G7h 473Xm9s4iPMV22fPUrYd8YUCz+EUgJVrsnyMAEqU= Date: Sun, 26 Jul 2020 11:42:24 +0200 From: Mauro Carvalho Chehab To: Rohit K Bharadwaj Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace Message-ID: <20200726114224.1825a769@coco.lan> In-Reply-To: <20200726090512.20574-2-bharadwaj.rohit8@gmail.com> References: <20200726062541.11304-1-bharadwaj.rohit8@gmail.com> <20200726090512.20574-2-bharadwaj.rohit8@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, 26 Jul 2020 14:35:12 +0530 Rohit K Bharadwaj escreveu: > this patch fixes style of open brace after functions and if statements > > Signed-off-by: Rohit K Bharadwaj > @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, > blob = (const unsigned char *)fw + bi->blob.offset; > > /* sanity check */ > - if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + bi->blob.data_size + bi->blob.padding_size) > - { > + if (bi->blob.size != > + bi->blob.text_size + bi->blob.icache_size + > + bi->blob.data_size + bi->blob.padding_size) { Please adjust the alignments here. I'm pretty sure checkpatch --strict will end complaining with the above, as the first line ends with "=". I would, instead, code it as: if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + bi->blob.data_size + bi->blob.padding_size) { Thanks, Mauro