From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lars@metafoo.de>
Subject: Re: [PATCH v2] iio: trigger: make stub functions static inline
Date: Sun, 26 Jul 2020 13:43:03 +0100 [thread overview]
Message-ID: <20200726134303.35c01f07@archlinux> (raw)
In-Reply-To: <20200720135133.72154-1-alexandru.ardelean@analog.com>
On Mon, 20 Jul 2020 16:51:33 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> From: Lars-Peter Clausen <lars@metafoo.de>
>
> Make sure that the trigger function stubs are all static inline.
> Otherwise we might see compiler warnings about declared but unused
> functions.
>
> Fixes 77712e5fbe2e4: ("Staging: iio: Staticise non-exported functions")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
As it's only warning suppression I'm not going to rush this one.
applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
>
> Changelog v1 -> v2:
> * fix commit description & title
> * added proper Fixes tag
>
> drivers/iio/iio_core_trigger.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h
> index 9d1a92cc6480..374816bc3e73 100644
> --- a/drivers/iio/iio_core_trigger.h
> +++ b/drivers/iio/iio_core_trigger.h
> @@ -30,7 +30,7 @@ int iio_trigger_detach_poll_func(struct iio_trigger *trig,
> * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers
> * @indio_dev: iio_dev associated with the device that will consume the trigger
> **/
> -static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
> +static inline int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
> {
> return 0;
> }
> @@ -39,7 +39,7 @@ static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
> * iio_device_unregister_trigger_consumer() - reverse the registration process
> * @indio_dev: iio_dev associated with the device that consumed the trigger
> **/
> -static void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
> +static inline void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
> {
> }
>
prev parent reply other threads:[~2020-07-26 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 14:24 [PATCH] iio: trigger: Staticise stub functions Alexandru Ardelean
2020-07-18 16:25 ` Jonathan Cameron
2020-07-18 16:36 ` Lars-Peter Clausen
2020-07-18 17:10 ` Ardelean, Alexandru
2020-07-20 13:51 ` [PATCH v2] iio: trigger: make stub functions static inline Alexandru Ardelean
2020-07-26 12:43 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726134303.35c01f07@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox