From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6034BC433DF for ; Sun, 26 Jul 2020 12:43:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4082820789 for ; Sun, 26 Jul 2020 12:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595767393; bh=rD1nqH0BQds6In7swJllLJX+GDj9Q+kPi3fN2kFuZg8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=fkrE9E03oZ8GQUNF4J00hu/bKQ2YOF2pmSDKeDdTtKseYlVIk5W7WhRHL90Tu9xSv Drg7Z7qk9ha/8kgGkJCEg6MQ1KBRypIBw4/rt2O9Ofj4va5kND4DlmFnAYha28sbhg qDLcKDtyfaGB1kHawbYOluxGEE02Hnr11fFZtAhA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727878AbgGZMnI (ORCPT ); Sun, 26 Jul 2020 08:43:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:44438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727038AbgGZMnH (ORCPT ); Sun, 26 Jul 2020 08:43:07 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58F9B2076A; Sun, 26 Jul 2020 12:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595767387; bh=rD1nqH0BQds6In7swJllLJX+GDj9Q+kPi3fN2kFuZg8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HSaFUNV/4NLoHCg1VodFMbHzZKRFNJ8jqhFlOQEO5M8+Zzs4o9MdrZKnoFbd7j5Ng Tp76SmsyRvOaQFTy8bXfK3M6jyjApUnHqf8WxmHYgtvyDqqdwSqN7KHATmljMpReFZ I6hpv13/ZeOOtA8NmbJCTeCFFyhQqN7pfQzzGAmU= Date: Sun, 26 Jul 2020 13:43:03 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , Subject: Re: [PATCH v2] iio: trigger: make stub functions static inline Message-ID: <20200726134303.35c01f07@archlinux> In-Reply-To: <20200720135133.72154-1-alexandru.ardelean@analog.com> References: <20200714142456.67054-1-alexandru.ardelean@analog.com> <20200720135133.72154-1-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jul 2020 16:51:33 +0300 Alexandru Ardelean wrote: > From: Lars-Peter Clausen > > Make sure that the trigger function stubs are all static inline. > Otherwise we might see compiler warnings about declared but unused > functions. > > Fixes 77712e5fbe2e4: ("Staging: iio: Staticise non-exported functions") > Signed-off-by: Lars-Peter Clausen > Signed-off-by: Alexandru Ardelean As it's only warning suppression I'm not going to rush this one. applied to the togreg branch of iio.git Thanks, Jonathan > --- > > Changelog v1 -> v2: > * fix commit description & title > * added proper Fixes tag > > drivers/iio/iio_core_trigger.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h > index 9d1a92cc6480..374816bc3e73 100644 > --- a/drivers/iio/iio_core_trigger.h > +++ b/drivers/iio/iio_core_trigger.h > @@ -30,7 +30,7 @@ int iio_trigger_detach_poll_func(struct iio_trigger *trig, > * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers > * @indio_dev: iio_dev associated with the device that will consume the trigger > **/ > -static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev) > +static inline int iio_device_register_trigger_consumer(struct iio_dev *indio_dev) > { > return 0; > } > @@ -39,7 +39,7 @@ static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev) > * iio_device_unregister_trigger_consumer() - reverse the registration process > * @indio_dev: iio_dev associated with the device that consumed the trigger > **/ > -static void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev) > +static inline void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev) > { > } >