Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to architecture only

Paul Cercueil
2020-07-24T15:19:52Z

Hi Krzysztof,

Le ven. 24 juil. 2020 à 16:54, Krzysztof Kozlowski <krzk@kernel.org> a
écrit :
> Enabling the MTD_NAND_JZ4780 driver makes sense only for specific
> hardware - the Ingenic SoC architecture. Set it's dependency to
> MACH_INGENIC so it will not appear on unrelated architectures (easier
> job for downstream/distro kernel engineers).

Disagreed. It was done this way so that distro kernels can support
multiple SoCs.

-Paul

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v2:
> 1. New patch
> ---
> drivers/mtd/nand/raw/ingenic/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig
> b/drivers/mtd/nand/raw/ingenic/Kconfig
> index 96c5ae8b1bbc..2e3936543ba6 100644
> --- a/drivers/mtd/nand/raw/ingenic/Kconfig
> +++ b/drivers/mtd/nand/raw/ingenic/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config MTD_NAND_JZ4780
> tristate "JZ4780 NAND controller"
> - depends on MIPS || COMPILE_TEST
> + depends on MACH_INGENIC || COMPILE_TEST
> depends on JZ4780_NEMC
> help
> Enables support for NAND Flash connected to the NEMC on JZ4780 SoC
> --
> 2.17.1
>