Re: [PATCH 06/23] md: remove the autoscan partition re-read

NeilBrown
2020-07-15T23:34:14Z

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On Tue, Jul 14 2020, Christoph Hellwig wrote:

> devfs is long gone, and autoscan works just fine without this these days.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Song Liu <song@kernel.org>

Happy to see this go!

Reviewed-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown

> ---
> drivers/md/md-autodetect.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/md/md-autodetect.c b/drivers/md/md-autodetect.c
> index 0eb746211ed53c..6bc9b734eee6ff 100644
> --- a/drivers/md/md-autodetect.c
> +++ b/drivers/md/md-autodetect.c
> @@ -240,16 +240,6 @@ static void __init md_setup_drive(void)
> err = ksys_ioctl(fd, RUN_ARRAY, 0);
> if (err)
> printk(KERN_WARNING "md: starting md%d failed\n", minor);
> - else {
> - /* reread the partition table.
> - * I (neilb) and not sure why this is needed, but I cannot
> - * boot a kernel with devfs compiled in from partitioned md
> - * array without it
> - */
> - ksys_close(fd);
> - fd = ksys_open(name, 0, 0);
> - ksys_ioctl(fd, BLKRRPART, 0);
> - }
> ksys_close(fd);
> }
> }
> --
> 2.27.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]