Re: [PATCH 17/23] initramfs: switch initramfs unpacking to struct file based APIs

Christoph Hellwig
2020-07-15T06:27:17Z

On Tue, Jul 14, 2020 at 12:31:01PM -0700, Linus Torvalds wrote:
> That "vcollected" is ugly and broken, and seems oh-so-wrong.
>
> Because it's only use is:
>
>
> > - ksys_close(wfd);
> > + fput(wfile);
> > do_utime(vcollected, mtime);
> > kfree(vcollected);
>
> which should just have done the exact same thing that you did with
> vfs_chown() and friends: we already have a "utimes_common()" that
> takes a path, and it could have been made into "vfs_utimes()", and
> then this whole vcollected confusion would go away and be replaced by
>
> vfs_truncate(&wfile->f_path, mtime);
>
> (ok, with all the "timespec64 t[2]" things going on that do_utime()
> does now, but you get the idea).
>
> Talk about de-crufting that initramfs unpacking..
>
> But I don't hate this patch, I'm just pointing out that there's room
> for improvement.

I'll send another series to clean this up. I had a few utimes related
patch in a later series and this fits in pretty well with those.