From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Xu Wang <vulab@iscas.ac.cn>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] intel_soc_pmic_mrfld: simplify the return expression of intel_scu_ipc_dev_iowrite8()
Date: Mon, 27 Jul 2020 13:53:35 +0100 [thread overview]
Message-ID: <20200727125335.GQ1850026@dell> (raw)
In-Reply-To: <20200727120908.GR3703480@smile.fi.intel.com>
On Mon, 27 Jul 2020, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 03:04:07AM +0000, Xu Wang wrote:
> > Simplify the return expression.
>
> I understand your intention, but I would rather leave as is.
> It's a bit more helpful in the original form in case to add some debugging.
If you wish to add debugging, you'll have to add the extra line of
code yourself. :)
> It also keep it symmetrical with read() counterpart.
Can this be fixed-up too?
> That said, I'm not objecting the change if Lee finds it good enough.
>
> > Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> > ---
> > drivers/mfd/intel_soc_pmic_mrfld.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-27 12:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 3:04 [PATCH] intel_soc_pmic_mrfld: simplify the return expression of intel_scu_ipc_dev_iowrite8() Xu Wang
2020-07-27 12:09 ` Andy Shevchenko
2020-07-27 12:53 ` Lee Jones [this message]
2020-07-27 13:00 ` Andy Shevchenko
2020-07-27 13:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727125335.GQ1850026@dell \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox