From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42E3C433EC for ; Mon, 27 Jul 2020 14:09:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8071221744 for ; Mon, 27 Jul 2020 14:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595858974; bh=PmqNglSethUnlEQrhNyXgEHuVzSZszf9Q54SGbecUY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TK50iFvth71V8aHMzlDI/fxk1khUxRr/Cf2+T0cj9LzSCdk6/Bd6zz4uCPdTxJhuf xyDcSkBwj8Wn64Zsmgs/zDSrNUp4OX9Wi9zjsux+MSxTS9hwxnk334zrcPXyc4bayc FN6ubmC4+yb9BBTEbUpqG3RIM9UohU8oxA538UN4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729661AbgG0OJc (ORCPT ); Mon, 27 Jul 2020 10:09:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:59634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728446AbgG0OJ3 (ORCPT ); Mon, 27 Jul 2020 10:09:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74F1E2073E; Mon, 27 Jul 2020 14:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595858969; bh=PmqNglSethUnlEQrhNyXgEHuVzSZszf9Q54SGbecUY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D/c7np6oCT3EI8p6N0hw5LiKkd07bcQNrbEx/Cc79XTdtwewO08hYztbHQuIibamH fGqjvuTdK4mEZVdTbm8qDrbHNBRojmenJeo7q2lYaxw83DnpuEqYqEyYRmNItiFocz Qc1eW74OiqLE0M0gCOmkcnBC7/oZRP1F+hXzHM4o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vladimir Oltean , Mark Brown , Guenter Roeck Subject: [PATCH 4.19 16/86] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when its not ours Date: Mon, 27 Jul 2020 16:03:50 +0200 Message-Id: <20200727134915.156933894@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134914.312934924@linuxfoundation.org> References: <20200727134914.312934924@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladimir Oltean commit d41f36a6464a85c06ad920703d878e4491d2c023 upstream. The DSPI interrupt can be shared between two controllers at least on the LX2160A. In that case, the driver for one controller might misbehave and consume the other's interrupt. Fix this by actually checking if any of the bits in the status register have been asserted. Fixes: 13aed2392741 ("spi: spi-fsl-dspi: use IRQF_SHARED mode to request IRQ") Signed-off-by: Vladimir Oltean Link: https://lore.kernel.org/r/20190822212450.21420-2-olteanv@gmail.com Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Cc: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-fsl-dspi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -878,9 +878,11 @@ static irqreturn_t dspi_interrupt(int ir trans_mode); } } + + return IRQ_HANDLED; } - return IRQ_HANDLED; + return IRQ_NONE; } static const struct of_device_id fsl_dspi_dt_ids[] = {